feat: allow using expo font for getImageSource #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
commented
Jul 8, 2025
| import { ensureGetImageAvailable } from './get-image-library'; | ||
|
|
||
| export const DEFAULT_ICON_SIZE = 12; | ||
| export const DEFAULT_ICON_COLOR = 'black'; |
There was a problem hiding this comment.
moved this to a separate file to avoid circular imports
| @@ -65,7 +63,11 @@ export function createIconSet<GM extends Record<string, number>>( | |||
| ): IconComponent<GM> { | |||
| const { postScriptName, fontFileName, fontStyle } = | |||
| typeof postScriptNameOrOptions === 'string' | |||
| ? { postScriptName: postScriptNameOrOptions, fontFileName: fontFileNameParam, fontStyle: fontStyleParam } | |||
| ? { | |||
| postScriptName: postScriptNameOrOptions, | |||
There was a problem hiding this comment.
reformatted by biome
| @@ -12,8 +12,6 @@ export default function createIconSourceCache() { | |||
|
|
|||
| const setError = (key: string, error: Error) => cache.set(key, { type: TYPE_ERROR, data: error }); | |||
|
|
|||
| const has = (key: string) => cache.has(key); | |||
There was a problem hiding this comment.
has is not needed - get() !== undefined is equivalent to that, and the value obtained by get() can be returned right away - as in packages/common/src/get-image-source.ts
| import { DEFAULT_ICON_COLOR, DEFAULT_ICON_SIZE } from './defaults'; | ||
| import { ensureGetImageAvailable } from './get-image-library'; | ||
|
|
||
| export const getImageSourceSync = ( |
There was a problem hiding this comment.
this is basically the same, just moved to a separate file for clarity
| NativeIconAPI.ensureNativeModuleAvailable(); | ||
|
|
||
| return NativeIconAPI; | ||
| if (hasExpoRenderToImage) { |
There was a problem hiding this comment.
this will kick in for expo-go
| throw new Error( | ||
| 'Could not import @react-native-vector-icons/get-image, did you install it? It is required for getImageSource*', | ||
| ); | ||
| if (NativeIconAPI) { |
There was a problem hiding this comment.
if @react-native-vector-icons/get-image is installed and the native module is available, use it
johnf
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the existing implementation by adding the ability to use
getImageSourceon Expo Go. The implementation usesrenderToImageAsyncfromexpo-fontto achieve that. This brings feature-parity with@expo/vector-iconsto this package - once this is done, all native (iOS, Android) features from@expo/vector-iconswill be usable also withreact-native-vector-icons(except those that were removed fromoblador/react-native-vector-icons-createMultiStyleIconSet).Test plan
Tested locally in Expo Go