feat: export types for icon names #1784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterlazar1993
changed the title
peterlazar1993
commented
Jun 26, 2025
| export type <%= className %><%= upperStyleName %>IconName = ComponentProps<typeof <%= upperStyleName %>Icon>['name']; | ||
| <% }) -%> |
There was a problem hiding this comment.
This maybe redundant, please check
vonovak
requested changes
Jul 4, 2025
| postScriptName: '<%= postScriptName %>', | ||
| fontFileName: '<%= fontFileName %>.ttf', | ||
| fontSource: require('../fonts/<%= fontFileName %>.ttf'), // eslint-disable-line @typescript-eslint/no-require-imports, global-require | ||
| }); | ||
|
|
||
| export default Icon; | ||
| export type <%= className %>IconName = ComponentProps<typeof <%= className %>>['name']; |
There was a problem hiding this comment.
Suggested change
| export type <%= className %>IconName = ComponentProps<typeof <%= className %>>['name']; | |
| export type <%= className %>IconName = keyof typeof glyphMap; |
this should be faster for TS since it won't have to introspect the component props
|
@peterlazar1993 thanks I updated the other PR with this and some other changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is duplicate of #1761, I just merged master and fixed conflicts.
Feel free to close this PR if rather you merge from main.
See the conflict resolution here