Skip to content

fix: handle APPLIED_LOCALLY state better in cloud fix ui #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

fix: handle APPLIED_LOCALLY state better in cloud fix ui #2642

merged 2 commits into from
Jul 30, 2025

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jul 30, 2025 •
edited
Loading

  • We need to make sure that the apply locally button doesn't just look disabled when there are local changes but that it also doesn't do anything
  • We need to handle the applied locally state explicitly in the UI so that you can't reject/apply it after already applying it locally.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 22934be

Command Status Duration Result
nx affected --targets=lint,test,build,e2e-ci,ty... ✅ Succeeded 1m 28s View ↗
nx-cloud record -- yarn nx sync:check ✅ Succeeded 3s View ↗
nx-cloud record -- ./gradlew :intellij:ktfmtChe... ✅ Succeeded 4s View ↗
nx-cloud record -- ./gradlew projectReportAll ✅ Succeeded 8s View ↗
nx affected --targets=build,test,e2e-ci --confi... ✅ Succeeded 22m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-30 10:48:14 UTC

@MaxKless MaxKless merged commit f34cfd1 into master Jul 30, 2025
6 checks passed
@MaxKless MaxKless deleted the fix-ui branch July 30, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxKless @JamesHenry