feat(migrate): add stop migration functionality and update commands #2567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When we run a migration via the migrate UI it runs as a separate process - Ensure that the webview is updated after changes have been made via run migration - Add stop command to kill a currently running migration
|
View your CI Pipeline Execution ↗ for commit 2f93a86.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Jun 18, 2025
jaysoo
requested changes
Jun 18, 2025
jaysoo
reviewed
Jun 18, 2025
jaysoo
approved these changes
Jun 19, 2025
MaxKless
approved these changes
Jun 24, 2025
ndcunningham
added a commit
to nrwl/nx
that referenced
this pull request
Jun 25, 2025
…on stopping functionality. (#31626) ## Overview This PR enhances the Migrate UI by adding a "Stop" button that allows users to halt in-progress migrations at any point during execution. It works in tandem with nrwl/nx-console#2567 ### Currently When a migration is running and needs to be stopped for any reason: - User accidentally triggered the migration - Migration is taking longer than expected - Changes are needed before completion Users must wait for the migration to complete before using the available "Undo" or "Skip" options. ### Expected Users should be able to stop a currently running migration at any time before it completes, providing immediate control over the migration process. ### Key Features: - Refactor guards to improve migration state checks and add conditions for running and completing migrations. - Update the state machine to handle new states for running, stopped, and evaluating migrations. - Implement logic to track running migrations and allow for stopping them gracefully. - Introduce a new process for running migrations in a separate child process to support cancellation. - Enhance metadata management to include stopped migrations and update UI accordingly. (The UI is completely driven by the backend now aka Nx Console) - Add tests to cover new migration states and behaviours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR works in tandem with nrwl/nx#31626 to enable the new Stop CTA inside of the Migrate UI.
Key Features
MISC