-
Notifications
You must be signed in to change notification settings - Fork 1.3k
nrf_security: fix undefined Kconfig option references #23168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
nrf_security: fix undefined Kconfig option references #23168
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: abefe9159e519ec51377af0ebd04f587804d269d more detailssdk-nrf:
Github labels
List of changed files detected by CI (11)
Outputs:ToolchainVersion: 187d9757da Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
.. _nrf_security_tls_header: | ||
|
||
User-provided Mbed TLS configuration header | ||
########################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this page?
If not, please also remove this line https://github.com/tomi-font/ncs/blob/security_fix_undefined_kconfig_references/doc/nrf/libraries/security/nrf_security/index.rst?plain=1#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as said in the commit message this information is outdated, it's not possible to do that anymore judging by our current Kconfig/Cmake logic.
And thanks for the link! I only searched for nrf_security_tls_header
which didn't yield any result and so thought that the page was included automatically in the TOC.
c2e542c
to
8375da6
Compare
To fix the build issue, change this line here https://github.com/nrfconnect/sdk-nrf/blob/main/doc/_utils/redirects.py#L556 to:
(Two lines instead of one, both pointing to index for redirects of any old links) |
8375da6
to
53972c7
Compare
Looking at the Kconfig and CMake logic it appears that providing your own configuration header file is not a possibility anymore. CONFIG_GENERATE_MBEDTLS_CFG_FILE doesn't exist anymore. Signed-off-by: Tomi Fontanilles <[email protected]>
CONFIG_PSA_USE_CRACEN_ASYMMETRIC_DRIVER has been removed in 3.1. Signed-off-by: Tomi Fontanilles <[email protected]>
Missing _C on most occurrences. Signed-off-by: Tomi Fontanilles <[email protected]>
To fix compliance. Signed-off-by: Tomi Fontanilles <[email protected]>
Remove or replace them. Signed-off-by: Tomi Fontanilles <[email protected]>
^ Signed-off-by: Tomi Fontanilles <[email protected]>
53972c7
to
abefe91
Compare
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-23168/nrf/app_dev/device_guides/nrf53/logging_nrf5340.html |
@magnev @nrfconnect/ncs-doc-leads please review |
See commits.