Skip to content

nrf_security: fix undefined Kconfig option references #23168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tomi-font
Copy link
Contributor

See commits.

@tomi-font tomi-font requested review from a team and magnev as code owners July 7, 2025 13:30
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 7, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 7, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: abefe9159e519ec51377af0ebd04f587804d269d

more details

sdk-nrf:

PR head: abefe9159e519ec51377af0ebd04f587804d269d
merge base: bc493723e2be19cfc0447fc03be5bca55a59dc59
target head (main): 377b5d3ba65f3288f93020e2f51166fa85947e19
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (11)
doc
│  ├── _utils
│  │  │ redirects.py
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf53
│  │  │  │  │  │ logging_nrf5340.rst
│  │  ├── libraries
│  │  │  ├── security
│  │  │  │  ├── nrf_security
│  │  │  │  │  ├── doc
│  │  │  │  │  │  │ mbed_tls_header.rst
│  │  │  │  │  │ index.rst
│  │  ├── security
│  │  │  ├── tfm
│  │  │  │  │ tfm_building.rst
modules
│  ├── trusted-firmware-m
│  │  ├── tfm_boards
│  │  │  ├── common
│  │  │  │  │ crypto_keys.c
samples
│  ├── bootloader
│  │  ├── socs
│  │  │  ├── nrf54l05_cpuapp.conf
│  │  │  │ nrf54l10_cpuapp.conf
subsys
│  ├── nrf_security
│  │  ├── cmake
│  │  │  │ generate_configs.cmake
│  │  ├── tfm
│  │  │  │ CMakeLists.txt
tests
│  ├── crypto
│  │  ├── src
│  │  │  │ common_test.h

Outputs:

Toolchain

Version: 187d9757da
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:187d9757da_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 4
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Comment on lines -1 to -4
.. _nrf_security_tls_header:

User-provided Mbed TLS configuration header
###########################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as said in the commit message this information is outdated, it's not possible to do that anymore judging by our current Kconfig/Cmake logic.
And thanks for the link! I only searched for nrf_security_tls_header which didn't yield any result and so thought that the page was included automatically in the TOC.

@tomi-font tomi-font force-pushed the security_fix_undefined_kconfig_references branch from c2e542c to 8375da6 Compare July 8, 2025 10:15
@tomi-font tomi-font requested a review from greg-fer July 8, 2025 10:15
@tomi-font tomi-font removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 8, 2025
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 8, 2025
@greg-fer
Copy link
Contributor

greg-fer commented Jul 8, 2025

To fix the build issue, change this line here https://github.com/nrfconnect/sdk-nrf/blob/main/doc/_utils/redirects.py#L556 to:

("libraries/nrf_security/doc/mbed_tls_header", "libraries/security/nrf_security/index"), # User-provided Mbed TLS configuration header (removed in v3.1.0)
("libraries/security/nrf_security/doc/mbed_tls_header", "libraries/security/nrf_security/index")

(Two lines instead of one, both pointing to index for redirects of any old links)

@tomi-font tomi-font force-pushed the security_fix_undefined_kconfig_references branch from 8375da6 to 53972c7 Compare July 8, 2025 12:11
@tomi-font tomi-font requested a review from a team as a code owner July 8, 2025 12:11
tomi-font added 6 commits July 8, 2025 15:21
Looking at the Kconfig and CMake logic it appears that providing your
own configuration header file is not a possibility anymore.
CONFIG_GENERATE_MBEDTLS_CFG_FILE doesn't exist anymore.

Signed-off-by: Tomi Fontanilles <[email protected]>
CONFIG_PSA_USE_CRACEN_ASYMMETRIC_DRIVER has been removed in 3.1.

Signed-off-by: Tomi Fontanilles <[email protected]>
Missing _C on most occurrences.

Signed-off-by: Tomi Fontanilles <[email protected]>
To fix compliance.

Signed-off-by: Tomi Fontanilles <[email protected]>
Remove or replace them.

Signed-off-by: Tomi Fontanilles <[email protected]>
@tomi-font tomi-font force-pushed the security_fix_undefined_kconfig_references branch from 53972c7 to abefe91 Compare July 8, 2025 12:21
Copy link

github-actions bot commented Jul 8, 2025

@tomi-font tomi-font removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 9, 2025
@tomi-font
Copy link
Contributor Author

@magnev @nrfconnect/ncs-doc-leads please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants