CODEOWNERS: Fix shields ownership overwrite #23148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidprzybylo
requested review from
piotrkoziar,
ankuns,
jangalda-nsc,
nordic-piks and
nordic-pikr
|
Issue spotted on PR: #22937, as changes was done on |
dawidprzybylo
force-pushed
the
Codeowners-update
branch
from
956f9f2 to
4fd84a8
Compare
This commit fixes an issue with shield ownership assignments in
the CODEOWNERS file:
- Moved the general shields pattern (**/shields/) above specific
shield entries
- Modified specific shield entries to include both teams:
- Added @nrfconnect/ncs-co-build-system to each specific shield entry
- Preserved original team assignments (@nrfconnect/ncs-low-level-test
and @nrfconnect/ncs-radio-sw)
- Removed misleading comment about shield entry positioning
The previous configuration caused specific shield owners to be
overwritten by the general @nrfconnect/ncs-co-build-system entry.
Signed-off-by: Dawid Przybylo <[email protected]>
dawidprzybylo
force-pushed
the
Codeowners-update
branch
from
4fd84a8 to
4d8694c
Compare
nordic-piks
approved these changes
Jul 7, 2025
jangalda-nsc
approved these changes
Jul 7, 2025
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 4d8694ca1c43183e579e2e1935dd3823d6012482 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ankuns
approved these changes
Jul 7, 2025
nordic-segl
approved these changes
Jul 7, 2025
bjarki-andreasen
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with shield ownership assignments in the CODEOWNERS file:
The previous configuration caused specific shield owners to be overwritten by the general @nrfconnect/ncs-co-build-system entry.