[nrf noup] bootutil: Locking KMU keys #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
approved these changes
Jul 8, 2025
tomi-font
reviewed
Jul 17, 2025
boot/bootutil/src/ed25519_psa.c
Outdated
Comment on lines
171
to
174
| psa_status_t status = psa_crypto_init(); | ||
|
|
||
| if (status != PSA_SUCCESS) { | ||
| BOOT_LOG_ERR("PSA crypto init failed with error %d", status); |
There was a problem hiding this comment.
Isn't psa_crypto_init() already called way before this?
There was a problem hiding this comment.
Yeah, actually it is. Probably.
de-nordic
force-pushed
the
key-locking
branch
3 times, most recently
from
7e3b7bf to
73564a6
Compare
tomi-font
approved these changes
Jul 18, 2025
boot/bootutil/src/ed25519_psa.c
Outdated
|
|
||
| void nrf_crypto_keys_housekeeping(void) | ||
| { | ||
| psa_status_t status = PSA_ERROR_BAD_STATE; |
There was a problem hiding this comment.
Why do we still initialize status?
There was a problem hiding this comment.
It does not hurt, that much.
There was a problem hiding this comment.
probably takes some ROM bytes 🙃 but yeah do what you want really just pointing it out
There was a problem hiding this comment.
Eh. There you have, happy now ?
Lock KMU keys before passing execution to application. Signed-off-by: Dominik Ermel <[email protected]>
|
nvlsianpu
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock KMU keys before passing execution to application.