[nrf noup] zephyr: Add support for ARM thumb filter #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
force-pushed
the
compressionprwiththumb
branch
from
a91ac9b to
945338a
Compare
de-nordic
reviewed
Sep 26, 2024
| if (rc) { | ||
| BOOT_LOG_ERR("Decompression error: %d", rc); | ||
| rc = BOOT_EBADSTATUS; | ||
|
|
There was a problem hiding this comment.
The empty line looks odd; somehow I think that it should be above rc = as the rc = and goto finish serve as "return".
de-nordic
reviewed
Sep 26, 2024
boot/zephyr/decompression.c
Outdated
|
|
||
| if (compression == NULL || compression->init == NULL || compression->deinit == NULL || | ||
| compression->decompress_bytes_needed == NULL || compression->decompress == NULL) { | ||
| if (compression_lzma == NULL || compression_lzma->init == NULL || |
There was a problem hiding this comment.
This basically begs for "is object valid" kind of function.
de-nordic
reviewed
Sep 26, 2024
boot/zephyr/decompression.c
Outdated
|
|
||
| if (compression == NULL || compression->init == NULL || compression->deinit == NULL || | ||
| compression->decompress_bytes_needed == NULL || compression->decompress == NULL) { | ||
| if (compression_lzma == NULL || compression_lzma->init == NULL || |
There was a problem hiding this comment.
The is "is object valid" function could be used here too.
nordicjm
force-pushed
the
compressionprwiththumb
branch
from
945338a to
31b797c
Compare
de-nordic
approved these changes
Oct 1, 2024
nordicjm
force-pushed
the
compressionprwiththumb
branch
from
31b797c to
3249524
Compare
Adds support for ARM thumb filter usage for compressed firmware updates Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
compressionprwiththumb
branch
from
3249524 to
7e94666
Compare
Adds ARM thumb filter to imgtool's LZMA2 compression. Upstream PR: mcu-tools/mcuboot#2084 Signed-off-by: Mateusz Michalek <[email protected]>
michalek-no
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.