Skip to content

fix: when no framework detected generate secret instead of throwing error #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

fix: when no framework detected generate secret instead of throwing error #23

merged 2 commits into from
Feb 5, 2025

Conversation

odeta939
Copy link
Contributor

@odeta939 odeta939 commented Feb 5, 2025

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

balazsorban44
balazsorban44 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a better default when we cannot detect a framework, thanks!

@balazsorban44 balazsorban44 merged commit a7d4214 into nextauthjs:main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odeta939 @balazsorban44