Skip to content

fix(neon): Fix test on Rust nightly #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

fix(neon): Fix test on Rust nightly #1113

merged 1 commit into from
Jul 25, 2025

Conversation

kjvalencik
Copy link
Member

The error message in Rust changed from already borrowed: BorrowMutError to RefCell already borrowed.

Copy link

🐰 Bencher Report

Branchkv/fix-nightly-test
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
ThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
Upper Boundary
operations / second (ops/s)
(Limit %)
JsFunction::bind📈 view plot
🚷 view threshold
215.87 ns
(+4.17%)Baseline: 207.24 ns
186.51 ns
(86.40%)
414.47 ns
(52.08%)
📈 view plot
🚷 view threshold
4,634,993.21 ops/s
(-3.63%)Baseline: 4,809,369.54 ops/s
0.00 ops/s
(0.00%)
5,290,306.49 ops/s
(87.61%)
JsFunction::call📈 view plot
🚷 view threshold
228.28 ns
(+3.88%)Baseline: 219.76 ns
197.79 ns
(86.64%)
439.53 ns
(51.94%)
📈 view plot
🚷 view threshold
4,383,715.36 ops/s
(-3.31%)Baseline: 4,533,980.74 ops/s
0.00 ops/s
(0.00%)
4,987,378.81 ops/s
(87.90%)
JsFunction::call_with📈 view plot
🚷 view threshold
192.22 ns
(-6.56%)Baseline: 205.71 ns
185.14 ns
(96.32%)
411.43 ns
(46.72%)
📈 view plot
🚷 view threshold
5,201,079.73 ops/s
(+7.47%)Baseline: 4,839,465.75 ops/s
0.00 ops/s
(0.00%)
5,323,412.33 ops/s
(97.70%)
auto-exported-noop📈 view plot
🚷 view threshold
27.79 ns
(-8.52%)Baseline: 30.38 ns
27.34 ns
(98.38%)
60.75 ns
(45.74%)
📈 view plot
🚷 view threshold
35,851,713.55 ops/s
(+6.61%)Baseline: 33,628,034.29 ops/s
0.00 ops/s
(0.00%)
36,990,837.72 ops/s
(96.92%)
hello-world📈 view plot
🚷 view threshold
58.46 ns
(+1.73%)Baseline: 57.46 ns
51.71 ns
(88.47%)
114.92 ns
(50.87%)
📈 view plot
🚷 view threshold
16,744,121.35 ops/s
(-3.39%)Baseline: 17,332,126.29 ops/s
0.00 ops/s
(0.00%)
19,065,338.92 ops/s
(87.82%)
manually-exported-noop📈 view plot
🚷 view threshold
28.96 ns
(+1.86%)Baseline: 28.43 ns
25.58 ns
(88.35%)
56.86 ns
(50.93%)
📈 view plot
🚷 view threshold
34,590,941.31 ops/s
(-1.54%)Baseline: 35,130,610.75 ops/s
0.00 ops/s
(0.00%)
38,643,671.82 ops/s
(89.51%)
🐰 View full continuous benchmarking report in Bencher

Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, LGTM

@kjvalencik kjvalencik merged commit 5793b62 into main Jul 25, 2025
32 checks passed
@kjvalencik kjvalencik deleted the kv/fix-nightly-test branch July 25, 2025 16:21
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.85%. Comparing base (2335828) to head (241385c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files          74       74           
  Lines        4701     4701           
  Branches     4701     4701           
=======================================
  Hits         3895     3895           
  Misses        713      713           
  Partials       93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants