Add Neon error codes #1110
Draft
Add Neon error codes #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | codex/implement-idea-from-issue-1079 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) | Upper Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|---|---|---|---|---|
| JsFunction::bind | 📈 view plot 🚷 view threshold | 239.45 ns(+15.66%)Baseline: 207.04 ns | 186.34 ns (77.82%) | 414.08 ns (57.83%) | 📈 view plot 🚷 view threshold | 4,175,390.81 ops/s(-13.27%)Baseline: 4,814,102.94 ops/s | 0.00 ops/s (0.00%) | 5,295,513.23 ops/s (78.85%) |
| JsFunction::call | 📈 view plot 🚷 view threshold | 223.20 ns(+2.05%)Baseline: 218.71 ns | 196.83 ns (88.19%) | 437.41 ns (51.03%) | 📈 view plot 🚷 view threshold | 4,475,638.30 ops/s(-1.71%)Baseline: 4,553,629.32 ops/s | 0.00 ops/s (0.00%) | 5,008,992.25 ops/s (89.35%) |
| JsFunction::call_with | 📈 view plot 🚷 view threshold | 194.64 ns(-5.69%)Baseline: 206.39 ns | 185.75 ns (95.43%) | 412.78 ns (47.15%) | 📈 view plot 🚷 view threshold | 5,138,415.88 ops/s(+6.06%)Baseline: 4,844,654.49 ops/s | 0.00 ops/s (0.00%) | 5,329,119.94 ops/s (96.42%) |
| auto-exported-noop | 📈 view plot 🚷 view threshold | 27.82 ns(-9.18%)Baseline: 30.63 ns | 27.57 ns (99.09%) | 61.26 ns (45.41%) | 📈 view plot 🚷 view threshold | 35,956,714.32 ops/s(+7.63%)Baseline: 33,406,874.69 ops/s | 0.00 ops/s (0.00%) | 36,747,562.15 ops/s (97.85%) |
| hello-world | 📈 view plot 🚷 view threshold | 58.42 ns(+1.77%)Baseline: 57.40 ns | 51.66 ns (88.43%) | 114.81 ns (50.89%) | 📈 view plot 🚷 view threshold | 16,804,194.93 ops/s(-3.17%)Baseline: 17,353,808.12 ops/s | 0.00 ops/s (0.00%) | 19,089,188.93 ops/s (88.03%) |
| manually-exported-noop | 📈 view plot 🚷 view threshold | 27.74 ns(-2.30%)Baseline: 28.39 ns | 25.55 ns (92.12%) | 56.78 ns (48.85%) | 📈 view plot 🚷 view threshold | 36,003,416.97 ops/s(+2.39%)Baseline: 35,163,272.22 ops/s | 0.00 ops/s (0.00%) | 38,679,599.44 ops/s (93.08%) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
- Coverage 84.34% 82.88% -1.47%
==========================================
Files 74 75 +1
Lines 5578 4733 -845
Branches 5578 4733 -845
==========================================
- Hits 4705 3923 -782
+ Misses 767 717 -50
+ Partials 106 93 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dherman
commented
Jul 14, 2025
| @@ -16,6 +16,8 @@ pub(super) enum Kind { | |||
| Task, | |||
| } | |||
|
|
|||
| use crate::error::ErrorCode; | |||
There was a problem hiding this comment.
All use statements should be placed in the top of the file.
| @@ -189,6 +189,8 @@ fn context_parse( | |||
| // * Context argument must be a `&mut` reference | |||
| // * First argument must not be `Channel` | |||
| // * Must not be a `self` receiver | |||
| use crate::error::{self, ErrorCode}; | |||
There was a problem hiding this comment.
Please place all use statements at the top of their files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ErrorCodeenum for compile-time diagnosticsdoc/error-codes.mdTesting
cargo test -p neon-macroscargo test -p ui-testcargo checkhttps://chatgpt.com/s/cd_68752f536f3081919816d5573dd4a091