chore: Use jpn for Japanese
#34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
Updates the Japanese locale code from ja to jpn across routing, middleware, components, API, and sitemap, and adds a redirect from /ja to /jpn.
- Switches all occurrences of the “ja” locale identifier to “jpn” in configuration, code, and link paths
- Updates middleware matcher, routing definitions, sitemap URLs, and redirect rules
- Adjusts UI components and form defaults to use the new
jpncode
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/middleware.ts | Matcher updated to include jpn instead of ja |
| src/i18n/routing.ts | Added jpn to locales array |
| src/i18n.ts | Exports updated to use jpn |
| src/components/Entry/Entry.tsx | Blockquote lang attribute switched to jpn |
| src/components/ContentInfo/ContentInfo.tsx | Language links updated to point to /jpn and rel/hreflang attributes removed |
| src/components/Composer/LanguageSelector.tsx | Segment value changed from ja to jpn |
| src/components/Composer/ComposerInput.tsx | Checks and lang prop updated for jpn |
| src/components/Composer/Composer.tsx | Source/target logic updated for jpn |
| src/app/sitemap.ts | Sitemap entries updated to /jpn |
| src/app/[locale]/page.tsx | Default source value switched to jpn |
| src/app/[locale]/_server.ts | Server logic now checks source === "jpn" |
| src/api/translate.ts | Prompt logic updated to use jpn |
| next.config.mjs | Added redirect from /ja to /jpn |
Comments suppressed due to low confidence (2)
src/components/Entry/Entry.tsx:49
- Using lang="jpn" may not be recognized by browsers and assistive technologies; consider using the standard BCP 47 two-letter code "ja" for HTML lang attributes while mapping internally to "jpn".
<blockquote lang="jpn">{parse(translationHTML)}</blockquote>
src/components/ContentInfo/ContentInfo.tsx:30
- Removing rel="alternate" and hrefLang attributes from language switch links may break SEO and language discovery; consider restoring those attributes on each to retain proper hreflang metadata.
<NextLink href="/ain-Latn">Aynu itak</NextLink>
neet
force-pushed
the
use-three-chars-lang-code
branch
from
8e750a0 to
39622e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.