Add Load State to TOC Accordion for Delayed or Deferred JS #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I need to test this in the coming days. Last time I merged something related to the js code it broke everything. =D |
|
@mtoensing thank you. Please let me know if there's any help in testing you need. We have modified your plugin temporarily, but you can see it working here with our Cookie/script settings implemented: https://www.boundless.com/immigration-resources/marriage-based-green-cards-explained/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
This PR introduces a check that checks if the DOM has already been loaded. If it has, it loads the TOC accordion as normal.
If the document hasn't already been loaded, then the
DOMContentLoadedevent is used to load the TOC.