Add advanced targeting for desktop users with 0 pinned tabs #12960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster
requested review from
jaredlockhart,
yashikakhurana and
freshstrangemusic
as code owners
freshstrangemusic
changed the title
freshstrangemusic
approved these changes
Jul 10, 2025
| name="Users who have no pinned tabs", | ||
| slug="no_pinned_tabs_desktop", | ||
| description=("Targets users who have 0 pinned tabs in their open windows."), | ||
| targeting=("!(hasPinnedTabs)"), |
There was a problem hiding this comment.
This doesnt need the ()
There was a problem hiding this comment.
ok, sorry I'm still finding my way around git and github workflows, but I think I have this updated correctly.
SUMMARY: SUCCESS: fenix at master (5836a062726f715fda621338a17b51aff30d0a8c) version None firefox_ios at main (e6e6bd1d63c7c835c44e4f28826d49e410f9585f) version None firefox_ios at release/v141 (60988e47a35b5d035e0fd99c5ed8b67868d1337c) version 141.0.0 firefox_ios at main (e6e6bd1d63c7c835c44e4f28826d49e410f9585f) version 142.0.0 focus_android at main (fe8a71cd70ad5674abe1824fe11dc78372b736c2) version None focus_ios at main (e6e6bd1d63c7c835c44e4f28826d49e410f9585f) version None focus_ios at release/v141 (60988e47a35b5d035e0fd99c5ed8b67868d1337c) version 141.0.0 focus_ios at main (e6e6bd1d63c7c835c44e4f28826d49e410f9585f) version 142.0.0 monitor_cirrus at main (8928f757fb2df2e36262456f73fc8bb34957cd1a) version None mozillavpn_backend_cirrus at main (04c37bf124c5ed285d34442426c3a06f8b21d73d) version None firefox_accounts_cirrus at main (9631a0e5501fe31e3267f3ccfd799819e668a4e9) version None firefox_desktop at central (8f464d9c468ba1a7c1b0338deaa8bc8023f8ae3d) version None firefox_desktop at central (8f464d9c468ba1a7c1b0338deaa8bc8023f8ae3d) version 142.0.0 firefox_desktop at beta (ab32f98a46735295222cf0f8998b7193d689b044) version 141.0.0 firefox_desktop at release (69deddbd8e11ffb6dea087aaad588a2758216e1e) version 140.0.5 firefox_desktop at esr115 (4abe91f6d0fc98716975cd7cfe1122d9955a8e0d) version 115.26.0 firefox_desktop at esr128 (4bdc152586ef5ef8645e13faffe0513f09f17fdd) version 128.13.0 experimenter_cirrus at main (2263f39) version None CACHED: fenix at master (5836a062726f715fda621338a17b51aff30d0a8c) version 142.0.0 (cached) fenix at beta (cf993125c635a7c61881ddf30807cc051c48190d) version 141.0.0 (cached) fenix at release (c61a6579702f4c73ee99131bd5fa216ec8f7b72c) version 140.0.5 (cached) firefox_ios at firefox-v137.0 (72386c1d3e182f6670926b3c1c3a09227fb7b120) version 137.0.0 (cached) firefox_ios at release/v138 (178f4e6c30adce3c6e04239de359bb00c1a5d94b) version 138.4.0 (cached) firefox_ios at release/v139 (0fc3b6546731da1c75fcbf06d7580ba6c64fab42) version 139.3.0 (cached) firefox_ios at release/v140 (00831cb025b21d305a63727850f511461d38d8fd) version 140.4.0 (cached) firefox_ios at firefox-v140.3 (b97fc73ef2df468c2c020013a2a7369f6e3fbb68) version 140.3.0 (cached) firefox_ios at firefox-v140.2 (e06518a809c6c98bf70147de1be100f597998473) version 140.2.0 (cached) firefox_ios at firefox-v140.1 (9ac126051d295037e061346535867992b11dc5dc) version 140.1.0 (cached) firefox_ios at firefox-v140.0 (9271e4103dac70d2b201346126a31a0300c59709) version 140.0.0 (cached) firefox_ios at firefox-v139.2 (edd4c97c5c320703fbc297d540218b1302a35742) version 139.2.0 (cached) firefox_ios at firefox-v139.1 (6c2ebc086ac39e0d4cbfdc2b8282ca05387a1744) version 139.1.0 (cached) firefox_ios at firefox-v139.0 (d2a59bf74e3e07dcf827e5da2756ca91f0aa19b5) version 139.0.0 (cached) firefox_ios at firefox-v138.3 (5a50592656796f94c23a392610813d53fa412590) version 138.3.0 (cached) firefox_ios at firefox-v138.2 (efb63a7f836c60039b615a534be0cf94666859ef) version 138.2.0 (cached) firefox_ios at firefox-v138.1 (0b5c4235adf039f03ac45a8b58614ca39b4fe9ab) version 138.1.0 (cached) firefox_ios at firefox-v138.0 (33f7f00718adf88505d1804ccedb56750b04f2fb) version 138.0.0 (cached) firefox_ios at firefox-v137.2 (51e7235310b5158aa559878b1054cd387870ff99) version 137.2.0 (cached) firefox_ios at firefox-v137.1 (e9e817d79663eaeb63e3dfe7ba222b1600823a51) version 137.1.0 (cached) focus_android at releases_v121 (979fbe8d7fe04a9b09fe657bb787fda6f4d5ab42) version 121.1.1 (cached) focus_android at releases_v122 (1fcbfc41dba53965481a0e4d4725833bf3669dce) version 122.1.1 (cached) focus_android at releases_v123 (5a38e0cb4499f659a5fff308fa1deee653c0318b) version 123.1.1 (cached) focus_android at releases_v124 (0ad8d97fb3ab2ec6b9bb3905ee742900a4b9325d) version 124.2.1 (cached) focus_android at releases_v125 (2b43ab8069abac2bfee4b609e734c0207876a2ac) version 125.3.1 (cached) focus_android at focus-v125.3.0 (9f2990415376f169eb0053fceb329b70b4421bcb) version 125.3.0 (cached) focus_android at focus-v125.2.0 (d1c6eeb4167fc8ffed02cdfd3138fa696381d548) version 125.2.0 (cached) focus_android at main (fe8a71cd70ad5674abe1824fe11dc78372b736c2) version 125.0.0 (cached) focus_android at focus-v124.2.0 (7a0e399c7bc4faae43ce70ddc201c7899498d1b5) version 124.2.0 (cached) focus_android at focus-v124.1.0 (516df33ca96e950af1bf791893cd16d7add61c5d) version 124.1.0 (cached) focus_android at focus-v124.0 (5afe87a5bbb92f7ecf990a2fbc8095503a47c272) version 124.0.0 (cached) focus_android at focus-v123.1.0 (cb7c807e0fb5bc08131415e2e5ecef9da658d410) version 123.1.0 (cached) focus_android at focus-v123.0 (f5f378e2c05c9d69a5088c112c14fdea507d1c65) version 123.0.0 (cached) focus_android at focus-v122.1.0 (0d665405685c43c9266a3de65f16eabb832bb908) version 122.1.0 (cached) focus_android at focus-v122.0.1 (c67c9e840c00ec348a6a27adedad28feb54aa4a2) version 122.0.1 (cached) focus_android at focus-v122.0 (b49c4f23804d23cc727b8f70c061dccd64d720bc) version 122.0.0 (cached) focus_android at focus-v121.1.0 (62d5117f7996cc8862fdbdc0cb4a1dd5cdebedd6) version 121.1.0 (cached) focus_android at focus-v121.0.1 (fd4d2513324712e91577d8be18797e64089d3cf1) version 121.0.1 (cached) focus_android at focus-v121.0 (1955f8455fa2cac1b2080af9360996c06df5b4dd) version 121.0.0 (cached) focus_ios at focus/klar-v137.0 (72386c1d3e182f6670926b3c1c3a09227fb7b120) version 137.0.0 (cached) focus_ios at release/v138 (178f4e6c30adce3c6e04239de359bb00c1a5d94b) version 138.4.0 (cached) focus_ios at release/v139 (0fc3b6546731da1c75fcbf06d7580ba6c64fab42) version 139.3.0 (cached) focus_ios at release/v140 (00831cb025b21d305a63727850f511461d38d8fd) version 140.4.0 (cached) focus_ios at focus/klar-v140.0 (2d3684ce1d30402082a7d37b3df58e0c672ac4ab) version 140.0.0 (cached) focus_ios at focus/klar-v139.0 (0a40db672ac6d422377ae4394dcbaae878998e9e) version 139.0.0 (cached) focus_ios at focus/klar-v138.0 (33f7f00718adf88505d1804ccedb56750b04f2fb) version 138.0.0 (cached) Circle CI Task: https://circleci.com/gh/mozilla/experimenter/337196
Because * We need to be able to upload screenshots for branches This commit * Adds the screenshot fields to the branch form * Adds create/delete screenshot views * Updates the branch page * Tests fixes mozilla#12878 https://github.com/user-attachments/assets/c0a69c42-b865-4484-b9f2-90f94b8b2823 Co-authored-by: Yashika Khurana <[email protected]>
Co-authored-by: Benjamin Forehand Jr <[email protected]>
…ozilla#12963) Because - Cirrus doesn't need to deploy every time experimenter is modified This commit - Early-exits the deploy cirrus CI job when no changes are detected to cirrus, fml, .circleci, or files in the root directory Fixes [EXP-5646](https://mozilla-hub.atlassian.net/browse/EXP-5646) along with https://github.com/mozilla/global-platform-admin/pull/3651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
!hasPinnedTabfor desktop users.Fixes #12959