Skip to content

Add character count to TextField #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add character count to TextField #483

merged 2 commits into from
Jun 5, 2024

Conversation

Lisa18289
Copy link
Member

No description provided.

@Lisa18289 Lisa18289 linked an issue Jun 5, 2024 that may be closed by this pull request
Add character count to TextField component #318
Closed
@Lisa18289 Lisa18289 changed the title feat(TextField): add character count Add character count to TextField Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 30.71% 4145 / 13493
🔵 Statements 30.71% 4145 / 13493
🔵 Functions 32.15% 164 / 510
🔵 Branches 54.83% 363 / 662
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/src/components/Icon/components/icons/index.ts 100% 100% 100% 100%
packages/components/src/components/TextArea/stories/Default.stories.tsx 0% 0% 0% 0% 1-70
packages/components/src/components/TextField/stories/Default.stories.tsx 0% 0% 0% 0% 1-93
packages/components/src/components/TextFieldBase/TextFieldBase.tsx 0% 0% 0% 0% 1-88
Generated in workflow #1060

@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook June 5, 2024 10:56 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview June 5, 2024 10:56 — with GitHub Actions Inactive
@mfal mfal force-pushed the 318-add-character-count-to-text-component branch from ad84b91 to 4c2be90 Compare June 5, 2024 12:20
@mfal mfal merged commit 86fcf6b into main Jun 5, 2024
3 of 4 checks passed
@mfal mfal deleted the 318-add-character-count-to-text-component branch June 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfal mfal mfal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add character count to TextField component
2 participants
@Lisa18289 @mfal