Skip to content

fix(PasswordCreationField): translations for char rules, correct behaviour for showing min or max rule #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

fix(PasswordCreationField): translations for char rules, correct behaviour for showing min or max rule #1728

merged 4 commits into from
Jul 10, 2025

Conversation

elmartinezc
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 33.98% 7780 / 22894
🔵 Statements 33.98% 7780 / 22894
🔵 Functions 63.69% 607 / 953
🔵 Branches 83.42% 1037 / 1243
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/PasswordCreationField/lib/generateValidationTranslation.ts 78.72% 73.68% 100% 78.72% 11-12, 20, 31-32, 46-50
Generated in workflow #3069 for commit 05f206a by the Vitest Coverage Report Action

@elmartinezc elmartinezc temporarily deployed to github-pages-preview-storybook July 9, 2025 12:04 — with GitHub Actions Inactive
@elmartinezc elmartinezc temporarily deployed to github-pages-preview July 9, 2025 12:04 — with GitHub Actions Inactive
@elmartinezc elmartinezc temporarily deployed to github-pages-preview-storybook July 9, 2025 14:20 — with GitHub Actions Inactive
@elmartinezc elmartinezc temporarily deployed to github-pages-preview July 9, 2025 14:20 — with GitHub Actions Inactive
@ins0 ins0 merged commit a484a29 into main Jul 10, 2025
4 checks passed
@ins0 ins0 deleted the fix/passwordFieldCharTranslation branch July 10, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jan-Eimertenbrink Jan-Eimertenbrink Jan-Eimertenbrink left review comments

@ins0 ins0 ins0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmartinezc @ins0 @Jan-Eimertenbrink