-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[Spec] Auto generate manifests for newer versions #236105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vedantmgoyal9
wants to merge
9
commits into
microsoft:master
Choose a base branch
from
vedantmgoyal9:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−0
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5eeeafd
[Spec] Auto generate manifests for newer versions
vedantmgoyal9 0a4010b
Fix file extension
vedantmgoyal9 659f8ea
Merge branch 'master' into patch-1
vedantmgoyal9 d8cf23d
Merge branch 'microsoft:master' into patch-1
ItzLevvie 8fce930
Merge branch 'microsoft:master' into patch-1
ItzLevvie bfa2144
Merge branch 'microsoft:master' into patch-1
ItzLevvie 3032996
Merge branch 'microsoft:master' into patch-1
ItzLevvie 32c8192
Merge branch 'microsoft:master' into patch-1
ItzLevvie 01ef8d8
Merge branch 'master' into patch-1
vedantmgoyal9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Fix file extension
commit 0a4010bd60751862cd32f76e81f44eb9cf72a96c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be better to have a separate directory structure specifically for auto-updates instead of including metadata in the
manifests
folder. While having the data right next to all of the manifests makes it easy for users to find, it greatly increases the complexity cost of a solution since whatever is built will have to recursively filter through all the directories to find the metadata files instead of filtering to only a known sub-tree