Show terminal size overlay (COLSxROWS) during resize (#2833)#20059
Open
sagarbhure-msft wants to merge 1 commit intomicrosoft:mainfrom
Open
Show terminal size overlay (COLSxROWS) during resize (#2833)#20059sagarbhure-msft wants to merge 1 commit intomicrosoft:mainfrom
sagarbhure-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Display a centered overlay showing columns x rows when the terminal control is resized. The overlay auto-hides after 750ms of inactivity. - Add ResizeOverlay Border element to TermControl.xaml - Add ViewWidth() to ControlCore (matches existing ViewHeight()) - Show overlay in _SwapChainSizeChanged using SafeDispatcherTimer Closes microsoft#2833
DHowett
reviewed
Apr 3, 2026
| const auto rows = coreImpl->ViewHeight(); | ||
| if (cols > 0 && rows > 0) | ||
| { | ||
| ResizeOverlayText().Text(std::to_wstring(cols) + L" \u00D7 " + std::to_wstring(rows)); |
Member
There was a problem hiding this comment.
nit: please prefer fmt::format over string concatenation
fmt::format(FMT_COMPILE(L"{0} \u00D7 {1}"), cols, rows)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Displays a centered overlay showing columns × rows when the terminal control is resized. The overlay auto-hides after 750ms.
References and Relevant Issues
Closes #2833
Detailed Description
When the user resizes the Terminal window, a themed overlay appears at the center showing dimensions in COLS × ROWS format (e.g. 100 × 27). Matches Konsole, iTerm2, and GNOME Terminal.
Changes (5 files, 52 lines):
Design decisions:
Validation Steps Performed
PR Checklist