Replace confirmCloseAllTabs with confirmOnClose#20055
Open
carlos-zamora wants to merge 1 commit intomainfrom
Open
Replace confirmCloseAllTabs with confirmOnClose#20055carlos-zamora wants to merge 1 commit intomainfrom
confirmCloseAllTabs with confirmOnClose#20055carlos-zamora wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Apologies if this is not the proper place for this question: is it possible to implement a fourth setting that would mean "present a warning dialog when closing multiple tabs/panes at once AND at least one background tab is in Running State"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary of the Pull Request
Replaces the
warning.confirmCloseAllTabssetting with awarning.confirmOnCloseenum setting that accepts the following:never: don't present a warning dialog when closing a sessionautomatic: present a warning dialog when closing multiple tabs/panes at oncealways: present a warning dialog when closing any sessionThe confirmation dialog contains a "don't ask me again" checkbox. When checked, we update the setting to
never.This setting also affects the following actions:
The appropriate confirmation dialog is shown in these scenarios. We also present an aggregate dialog instead of prompting the user once per tab/pane. If there are no other tabs/panes, we don't present a dialog and treat the key binding as unhandled (passing the key through).
References and Relevant Issues
Iteration of #19944
Validation Steps Performed
PR Checklist
Closes #5301
Closes #6641
"don't ask me again" checkbox is also mentioned in #10000
Co-authored by @zadjii-msft