Fix DECSTR cursor restore in alt screen buffer (#19918)#20032
Open
aarushisingh04 wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix DECSTR cursor restore in alt screen buffer (#19918)#20032aarushisingh04 wants to merge 1 commit intomicrosoft:mainfrom
aarushisingh04 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
DHowett
requested changes
Mar 30, 2026
caac812 to
4cf71d3
Compare
Author
|
@DHowett apologies, it has been addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary of the pull request
fixes decstr behavior so a soft reset in the alt screen buffer does not clear the saved cursor state for the main screen buffer.
references and relevant issues
detailed description of the pull request / additional comments
the prior implementation of
AdaptDispatch::SoftReset()reset both saved cursor states unconditionally:this caused a regression where sending
decstr(esc[!p) while in the alt buffer could clear the main buffer cursor restore point, so returning from alt buffer no longer restored the expected cursor position.this change updates soft reset behavior to clear only the saved cursor state for the currently active buffer, matching expected xterm-compatible behavior and preserving main buffer cursor restore data when resetting in alt mode.
a regression unit test was added to cover this scenario:
decstrvalidation steps performed
Conhost.Unit.Tests.dll