ch: detect VMM version from git repository for Docker-based tests #4256
+114
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Cloud Hypervisor performance test metadata reporting by improving how the cloud-hypervisor VMM version is detected and made available to platform/environment information collection (especially for Docker-based tests that build from source).
Changes:
- Enhance
get_vmm_version()to prefer a cached value, then fall back to local binary version output, then togit describefrom the cloned repo. - Cache the detected VMM version during
CloudHypervisorTeststool installation for later use by platform information hooks. - Update Cloud Hypervisor test case signatures to accept
Environment(framework injection alignment).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lisa/sut_orchestrator/platform_utils.py | Adds cached + git-repo-based VMM version detection logic. |
| lisa/microsoft/testsuites/cloud_hypervisor/ch_tests_tool.py | Caches detected VMM version post-install for later metadata collection. |
| lisa/microsoft/testsuites/cloud_hypervisor/ch_tests.py | Adds Environment parameter to CH test cases for framework injection consistency. |
**Key Test Cases:**
verify_cloud_hypervisor_performance_metrics_tests|verify_cloud_hypervisor_integration_tests
**Impacted LISA Features:**
Virtualization
**Tested Azure Marketplace Images:**
- canonical 0001-com-ubuntu-server-jammy 22_04-lts latest
- microsoftcblmariner azure-linux-3 azure-linux-3 latest
vyadavmsft
force-pushed
the
vyadav_jan_fix3
branch
3 times, most recently
from
307db8b to
f00b53e
Compare
LiliDeng
reviewed
Feb 1, 2026
Collaborator
|
@copilot please rebase the latest main into this branch. |
Contributor
4 tasks
vyadavmsft
force-pushed
the
vyadav_jan_fix3
branch
from
f00b53e to
8dfa4ea
Compare
Collaborator
Author
i did the rebase. |
Problem: Cloud-hypervisor performance tests report VMM version as 'UNKNOWN' instead of actual version (e.g., '48.0.235'). Tests run cloud-hypervisor inside Docker containers which are build environments without pre-compiled binaries, making binary-based version detection unreliable. Root Cause: 1. Tests execute cloud-hypervisor by compiling from source inside Docker build containers 2. Previous version detection attempted to query non-existent binaries in Docker images 3. Version detection ran during teardown when SSH session was closing, causing failures
vyadavmsft
force-pushed
the
vyadav_jan_fix3
branch
from
8dfa4ea to
48e4916
Compare
Collaborator
Author
|
@LiliDeng can you check this , something not right with pr checks |
LiliDeng
reviewed
Feb 4, 2026
| # even during teardown when the node may be disconnected. | ||
| extended_resources = getattr(node.capability, "extended_resources", None) | ||
| if extended_resources: | ||
| cached_version: str = extended_resources.get( |
Collaborator
There was a problem hiding this comment.
Actually, it doesn't cache the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Cloud-hypervisor performance tests report VMM version as 'UNKNOWN' instead of actual version (e.g., '48.0.235'). Tests run cloud-hypervisor inside Docker containers which are build environments without pre-compiled binaries, making binary-based version detection unreliable.
Root Cause:
Solution: