-
Notifications
You must be signed in to change notification settings - Fork 38
feat(hve-core-guidance-instructions): update guidance artifacts and MCP config #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 - Generated by Copilot
…t tool When dispatching a subagent, state that it must proceed without access to `runSubagent`, completing tasks directly. 🔧 - Generated by Copilot
🔒 - Generated by Copilot
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 60.96% 60.93% -0.04%
==========================================
Files 19 19
Lines 3233 3233
==========================================
- Hits 1971 1970 -1
- Misses 1262 1263 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an agent frontmatter field to the pull request prompt, introduces HVE Core location fallback guidance for missing artifacts, and clarifies runSubagent limitations when dispatching subagents in the RPI agent.
Changes:
- Added
agent: agentfrontmatter field to the pull request prompt definition - Created new location fallback instructions for missing prompts, instructions, agents, or scripts
- Enhanced RPI agent guidance to inform subagents about
runSubagentunavailability
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/prompts/pull-request.prompt.md |
Added agent frontmatter field to delegate prompt execution to an agent |
.github/instructions/hve-core-location.instructions.md |
New instruction file providing fallback guidance for locating missing artifacts |
.github/agents/rpi-agent.agent.md |
Added clarification about subagent runSubagent limitations when dispatching |
katriendg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice approach!
Approving but note you may need to update your PR description around MCP settings, no mcp.json file is part of this PR as far as I see...
feat(hve-core-guidance-instructions): update guidance artifacts and MCP config
Description
This PR updated guidance artifacts for subagent behavior and location fallback rules, and expanded MCP configuration inputs and servers.
agentfrontmatter field to the pull request prompt definition.runSubagentlimitations when dispatching subagents in the RPI agent guidance..vscode/mcp.jsonwith Azure DevOps inputs and new MCP servers for Terraform, Context7, Microsoft Docs, and Azure DevOps.Details
This works by abusing this part of the System Message for GitHub Copilot:
Related Issue(s)
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
User Request:
Generate a PR description from
pr-reference.xmland ensure it follows the repository template.Execution Flow:
pr-reference.xmlto capture commit history and diffs.Output Artifacts:
pr.mdSuccess Indicators:
pr-reference.xml.For detailed contribution requirements, see:
Testing
Not run (not requested).
Checklist
Required Checks
AI Artifact Contributions
/prompt-analyzeto review contributionprompt-builderreviewRequired Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run lint:md-linksnpm run lint:psSecurity Considerations
Additional Notes