Unify sys impl under a trait #619
Open
+954
−895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
xosnrdev
changed the title
|
Thank you for working on this! Once you'd like me to review this, please feel free to unmark it as draft. 🙂 |
xosnrdev
force-pushed
the
unify-virtmem
branch
from
87e1b7e to
9943f73
Compare
xosnrdev
commented
Aug 21, 2025
Comment on lines
+131
to
+134
| let load_read_func = |module: *const u16| -> apperr::Result<ReadConsoleInputExW> { | ||
| get_module(module) | ||
| .and_then(|m| get_proc_address(m, c"ReadConsoleInputExW".as_ptr())) | ||
| } | ||
| } | ||
| STATE.read_console_input_ex = match load_read_func(w!("kernel32.dll")) { | ||
| Ok(func) => func, | ||
| Err(err) => match load_read_func(w!("kernelbase.dll")) { | ||
| .and_then(|m| Self::get_proc_address(m, c"ReadConsoleInputExW".as_ptr())) | ||
| }; |
There was a problem hiding this comment.
I figured I should point this out.
Changed load_read_func into a closure since the nested fn couldn’t use Self and Clippy wasn’t happy tho behavior remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully satisfies:
edit/src/sys/unix.rs
Line 7 in 695d88e