Add feature to open folder from terminal command

[four-poetic-drew]

Introduce an argument that triggers the file picker to open immediately in the current directory when using edit . command in terminal

Addresses issue #543 feature request to open a folder.

[deadalusai]

I'm not sure what the application should do if the user specifies a number of directory path arguments - perhaps use only the first or last one.

E.g. edit ./foo/ ./file.txt ./bar/

• Open one buffer for file.txt
• Launch file picker on foo/?
• Launch file picker on bar/?

[deadalusai]

Instead of checking for . specifically, you could instead check to see if arg represents a directory path?

E.g. below where we filter out directories, something like:

if p.is_dir() {
    state.wants_file_picker = StateFilePicker::Open;
    state.file_picker_pending_dir = DisplayablePathBuf::from_path(p);
    ...
}
else {
    paths.push(p);
}

This would allow you to type something like edit ., or edit ./src, etc.

[four-poetic-drew]

That makes sense, thanks. Have updated. Seems to work sensibly:

edit . -> opens current folder
edit ./src -> opens src
edit <file> -> still opens file correctly
edit <folder> -> opens folder in current directory

[four-poetic-drew]

I'm not sure what the application should do if the user specifies a number of directory path arguments - perhaps use only the first or last one.

E.g. edit ./foo/ ./file.txt ./bar/

• Open one buffer for file.txt
• Launch file picker on foo/?
• Launch file picker on bar/?

Right now it just picks up the first argument. I'd be happy with that.

Tried playing around with the code command with vscode and couldn't really spot what it was doing -> think the open last workspace features were interfering.

[lhecker]

I'm not entirely sure about early-returning here as we may miss non-directory arguments that we still need to open as documents. I'll think about it some more and probably merge it even in the current state. But I'd encourage you to try and restructure the code to make this possible.

More importantly, please run cargo fmt. 🙂

[four-poetic-drew]

Thanks, I have run cargo fmt now.

Am I correct in understanding that the non-directory argument you refer to means desired behaviour running edit file.txt opens the file.txt file?

I think currently it still does that as the return isn't reached if p.is_dir() does not return true. Instead it goes into the else block of paths.push(p) as it did before.

Happy to try to restructure the code, just not sure I understand correctly the ask.

[lhecker]

No, I meant what happens if you run edit /path/ file.txt. Should it open file.txt and also open the file picker? I think so.