Skip to content

Fix #485: Reject invalid args and allow positional args #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025

Conversation

spinualexandru
Copy link
Contributor

@spinualexandru spinualexandru commented Jun 20, 2025

  • Added rejections for invalid arguments
  • Added positional arguments so in case you are running "edit -- -?" it will allow you to create a file called "-?"

Closes #485

@lhecker
Copy link
Member

lhecker commented Aug 12, 2025

While I think that your PR generally went into the right direction, I've reduced its complexity a bit to address the issue first, by removing the logic to reject invalid arguments.

@lhecker lhecker requested a review from DHowett August 12, 2025 12:19
@lhecker lhecker merged commit f17552c into microsoft:main Aug 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Linux edit -? creates a file named -?
3 participants