Skip to content

[CmdPal > Ext] Use empty content for WindowWalker, Windows Settings and Windows Search #40722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[CmdPal > Ext] Use empty content for WindowWalker, Windows Settings and Windows Search #40722

wants to merge 9 commits into from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Jul 20, 2025 •
edited
Loading

Summary of the Pull Request

This PR improves the behavior of CmdPal on empty or wrong search query for the following exts:

  • Window Walker
  • Windows Settings
  • Windows Search (indexer)

Window Walker

image

Windows Settings - Empty query

image

Windows Settings - No search match

image

Windows search (indexer)

image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@htcfreek htcfreek self-assigned this Jul 20, 2025
@htcfreek htcfreek added Idea-Enhancement New feature or request on an existing product CmdPal-Inbox Extensions Needs-Review This Pull Request awaits the review of a maintainer. labels Jul 20, 2025
@htcfreek htcfreek changed the title [CmdPal > Ext] WindowWalker & Windows Settings: Use empty content [CmdPal > Ext] Use empty content for WindowWalker, Windows Settings and Windows Search Jul 20, 2025
@michaeljolley michaeljolley added the Product-Command Palette Refers to the Command Palette utility label Jul 20, 2025
michaeljolley
michaeljolley approved these changes Jul 20, 2025
View reviewed changes
Copy link
Contributor

@michaeljolley michaeljolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Best GIF

@michaeljolley
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

niels9001
niels9001 requested changes Jul 21, 2025
View reviewed changes
@htcfreek
Copy link
Collaborator Author

htcfreek commented Jul 21, 2025 •
edited
Loading

@niels9001
Requested changes done. See updated screenshots.

@michaeljolley
Do we have a bug (in main) that CmdPal isn't hiding from taskbar after executing result commands? The taskbar item is hiding for a short time and then reoccurs.
image

@htcfreek htcfreek requested a review from niels9001 July 21, 2025 18:37
@michaeljolley
Copy link
Contributor

I think it only does that in debug sessions.

@htcfreek
Copy link
Collaborator Author

I think it only does that in debug sessions.

That makes sense. 💡

zadjii-msft
zadjii-msft reviewed Jul 22, 2025
View reviewed changes
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Indexer/Pages/IndexerPage.cs
{
Icon = Icon,
Title = Resources.Indexer_Subtitle,
Subtitle = Resources.Indexer_NoResultsMessage + "\n\n" + Resources.Indexer_NoResultsMessageTip,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we only include this Subtitle when the user has actually typed something? Seems weird to say "no results found" if the user hasn't actually typed something

Copy link
Collaborator Author

@htcfreek htcfreek Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zadjii-msft
but ww for examples shows a list of open windows if you open the page. or do you only asking for file explorer?

How dynamic is the backend. Does it cache the data?

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowWalker/Pages/WindowWalkerListPage.cs
{
Icon = Icon,
Title = Resources.window_walker_top_level_command_title,
Subtitle = Resources.windowwalker_NoResultsMessage,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft left review comments

@michaeljolley michaeljolley michaeljolley approved these changes

@niels9001 niels9001 niels9001 approved these changes

Assignees

@htcfreek htcfreek

Labels
CmdPal-Inbox Extensions Idea-Enhancement New feature or request on an existing product Needs-Review This Pull Request awaits the review of a maintainer. Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@htcfreek @michaeljolley @niels9001 @zadjii-msft