Fixed GitHub issue 4039: Incorrect update of test methods in data-dri… #4164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved test codeunits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4039
PR #2831 fixed the issue for test codeunits not linked to any data input group, since the "Expand Data-Driven Tests" subscriber now does not get bound if the data input group in the test line is empty. Still the bug persists in data-driven tests.
Same repro steps as reported in #4039 can be followed, but the Codeunit 1, which is being updated, must have a data input group assigned. When running the "Update Test Methods" action on a data-driven test, test methods end up landing under the wrong codeunit name in the test tool page.
This can be fixed by reconciling the line numbering in the data-driven tests with the "Test Runner - Get Methods" codeunit which triggers the event, through an additional even parameter.