Skip to content

Update CalculationBaseType.Enum.al #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AydinKelky
Copy link

@AydinKelky AydinKelky commented Jul 11, 2025

Summary

Update CalculationBaseType.Enum.al to Extensible=True

Work Item(s)

Fixes #4092

@AydinKelky AydinKelky requested a review from a team as a code owner July 11, 2025 11:22
@github-actions github-actions bot added the From Fork Pull request is coming from a fork label Jul 11, 2025
@NKarolak
Copy link
Contributor

Making an Enum extensible typically (but not always) requires adding events to handle possible custom values. Have you already checked where and how this Enum is used?

@AydinKelky
Copy link
Author

@NKarolak The enum will be used in sales subscription line from Subscription package and after posting, subscription line and customer contract subscription line but I don't undestand your question. Why for an enum to be extensible should an event be defined?

@NKarolak
Copy link
Contributor

NKarolak commented Jul 14, 2025

The standard code uses this Enum somewhere, I suppose.
Unless the Enum is part of an interface, you will typically find standard code that handles specific enum values (either with if or case). In such places, you need to check whether there is an event that other (your!) apps extending the Enum can subscribe to handle your custom enum values.

@AydinKelky
Copy link
Author

@NKarolak Thanks for the clarification. There are some parts that use this enum as a parameter(case or if). Should I create events for the parts that might be causing a problem?

@NKarolak
Copy link
Contributor

NKarolak commented Jul 14, 2025

Should I create events for the parts that might be causing a problem?

Yes please.

If you are too unsure, maybe somebody else (Microsoft?) could close that gap later.
@JesperSchulz, does it need to be solved already in this PR? Could you assist here?

@AydinKelky
Copy link
Author

@NKarolak It would be great if someone from Microsoft could help me with this. Thank you for your help as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
From Fork Pull request is coming from a fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enum 8052 "Calculation Base Type" in "Microsoft Subscription Billing" is set as not extensible
2 participants