Skip to content

6275 – Finish CI deploy action #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

Conversation

vasconsaurus
Copy link
Contributor

@vasconsaurus vasconsaurus commented May 21, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context – why has this been changed/fixed.

References: 6275

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can verify the changes. Please describe whether or not you implemented automated tests.

Things to pay attention to during code review

Please describe parts of the change that require extra attention during code review, for example:

  • File FFFF, line LL: This refactoring does this and this. Is it consistent with how it’s implemented elsewhere?
  • Etc.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@vasconsaurus vasconsaurus requested a review from dmou as a code owner May 21, 2025 19:07
@vasconsaurus vasconsaurus changed the title 6275 – Finish CI deploy actio 6275 – Finish CI deploy action May 21, 2025
@vasconsaurus vasconsaurus requested a review from dmou May 21, 2025 19:32
Copy link
Contributor

@dmou dmou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴

@caiosba caiosba removed their request for review May 21, 2025 19:33
@vasconsaurus vasconsaurus force-pushed the 6275-finish-ci-deploy-action branch from 5e45ce4 to fdb28a7 Compare May 21, 2025 19:39
@vasconsaurus vasconsaurus merged commit dc1165e into develop May 21, 2025
5 checks passed
@vasconsaurus vasconsaurus deleted the 6275-finish-ci-deploy-action branch May 21, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants