refactor(console,phrases): refactor custom profile field creation modal #7647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charIeszhao
requested review from
wangsijie,
xiaoyijun and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/pages/SignInExperience/PageContent/CollectUserProfile/CreateProfileFieldModal/index.tsx | 📈 +182 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/CollectUserProfile/consts.ts | 📈 +179 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/components/CustomDataProfileNameField/index.module.scss | 📈 +101 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/components/CustomDataProfileNameField/index.tsx | 📈 +191 Bytes |
| packages/phrases/src/locales/ar/errors/custom-profile-fields.ts | 📈 +156 Bytes |
| packages/phrases/src/locales/de/errors/custom-profile-fields.ts | 📈 +131 Bytes |
| packages/phrases/src/locales/en/errors/custom-profile-fields.ts | 📈 +115 Bytes |
| packages/phrases/src/locales/es/errors/custom-profile-fields.ts | 📈 +136 Bytes |
| packages/phrases/src/locales/fr/errors/custom-profile-fields.ts | 📈 +137 Bytes |
| packages/phrases/src/locales/it/errors/custom-profile-fields.ts | 📈 +134 Bytes |
| packages/phrases/src/locales/ja/errors/custom-profile-fields.ts | 📈 +170 Bytes |
| packages/phrases/src/locales/ko/errors/custom-profile-fields.ts | 📈 +151 Bytes |
| packages/phrases/src/locales/pl-pl/errors/custom-profile-fields.ts | 📈 +146 Bytes |
| packages/phrases/src/locales/pt-br/errors/custom-profile-fields.ts | 📈 +136 Bytes |
| packages/phrases/src/locales/pt-pt/errors/custom-profile-fields.ts | 📈 +138 Bytes |
| packages/phrases/src/locales/ru/errors/custom-profile-fields.ts | 📈 +224 Bytes |
| packages/phrases/src/locales/tr-tr/errors/custom-profile-fields.ts | 📈 +131 Bytes |
| packages/phrases/src/locales/zh-cn/errors/custom-profile-fields.ts | 📈 +109 Bytes |
| packages/phrases/src/locales/zh-hk/errors/custom-profile-fields.ts | 📈 +106 Bytes |
| packages/phrases/src/locales/zh-tw/errors/custom-profile-fields.ts | 📈 +112 Bytes |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the custom profile field creation modal to improve user experience and validation. The main focus is on filtering out already-added fields and enhancing error handling.
- Filters built-in user profile fields from the modal instead of just disabling them
- Adds validation to prevent conflicts with built-in profile properties
- Improves error message styling for custom field inputs
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/phrases/src/locales/*/errors/custom-profile-fields.ts | Adds new error message for built-in property conflicts across all locales |
| packages/console/src/pages/SignInExperience/PageContent/components/CustomDataProfileNameField/index.tsx | Extracts error prop and renders custom error message |
| packages/console/src/pages/SignInExperience/PageContent/components/CustomDataProfileNameField/index.module.scss | Adds styling for error messages |
| packages/console/src/pages/SignInExperience/PageContent/CollectUserProfile/consts.ts | Defines available built-in field keys |
| packages/console/src/pages/SignInExperience/PageContent/CollectUserProfile/CreateProfileFieldModal/index.tsx | Implements field filtering and built-in property validation |
.../src/pages/SignInExperience/PageContent/CollectUserProfile/CreateProfileFieldModal/index.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Checklist
- [ ].changeset- [ ] unit tests- [ ] integration tests- [ ] necessary TSDoc comments