-
-
Notifications
You must be signed in to change notification settings - Fork 563
feat(core): add anonymous Google One Tap config API #7401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/routes/google-one-tap/index.openapi.json | 📈 +1.52 KB |
packages/core/src/routes/google-one-tap/index.ts | 📈 +3.52 KB |
packages/core/src/routes/init.ts | 📈 +107 Bytes |
packages/core/src/routes/swagger/utils/documents.ts | 📈 +140 Bytes |
packages/core/src/routes/swagger/utils/general.ts | 📈 +100 Bytes |
packages/core/src/routes/swagger/utils/operation-id.ts | 📈 +58 Bytes |
packages/integration-tests/src/tests/api/google-one-tap.test.ts | 📈 +3.8 KB |
1354f49
to
46acf09
Compare
46acf09
to
2028ed6
Compare
4ec6e50
to
489e697
Compare
489e697
to
e688bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an anonymous Google One Tap config API to allow various Logto websites to directly retrieve the Google One Tap configuration without setting environment variables for each site.
- Added integration tests for the new API endpoint.
- Updated Swagger documentation and operation IDs for the new route.
- Integrated the new route into the core routing setup.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
packages/integration-tests/src/tests/api/google-one-tap.test.ts | Added tests for various API responses and CORS handling. |
packages/core/src/routes/swagger/utils/operation-id.ts | Updated route-to-operation mapping with the new Google One Tap API. |
packages/core/src/routes/swagger/utils/general.ts | Extended tagMap to include Google One Tap when dev features are enabled. |
packages/core/src/routes/swagger/utils/documents.ts | Included Google One Tap in management API entities and additional tags. |
packages/core/src/routes/init.ts | Imported and registered the new Google One Tap routes. |
packages/core/src/routes/google-one-tap/index.ts | Implemented the new API endpoint with CORS validation and config parsing. |
packages/core/src/routes/google-one-tap/index.openapi.json | Documented the new endpoint in the OpenAPI schema. |
packages/integration-tests/src/tests/api/google-one-tap.test.ts
Outdated
Show resolved
Hide resolved
396874e
to
10bef09
Compare
10bef09
to
2bc5653
Compare
Summary
add anonymous Google One Tap config API (resolves LOG-11506)
With this API, all Logto website (including official website, docs, blog and so on) can direct read Google One Tap (GOT) config from this API and no need to set GOT config to env variables for each website.
Testing
Add integration tests.
Checklist
.changeset