feat: check auth status on cloud console #1126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a cross-domain authentication status check that verifies admin token validity using an iframe-based approach and integrates it into the Docusaurus layout. Key changes include:
- Adding new types and enum definitions for auth status checking in src/theme/Layout/types.ts.
- Implementing the auth status check mechanism, including debug logging, polling, and global exposure of auth state in src/theme/Layout/index.tsx.
- Updating the Docusaurus configuration to support the new auth status check feature via new customFields.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/theme/Layout/types.ts | Added types and enums to define the cross-domain auth status check functionality. |
| src/theme/Layout/index.tsx | Integrated auth status checking into the layout with appropriate debug logging and polling. |
| docusaurus.config.ts | Updated customFields to include new environment variables for the auth status check feature. |
| if (isIframeVisible) { | ||
| // In debug mode, delay removal to allow inspection | ||
| iframe.style.border = '2px solid green'; // Change border color to indicate success | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Consider extracting the various timeout durations (e.g., 5000ms and 10000ms) into named constants for better maintainability and consistency across the auth status check implementation.
Copilot uses AI. Check for mistakes.
darcyYe
force-pushed
the
yemq-add-auth-status-check
branch
from
aa6815f to
8087b48
Compare
Deploying logto-docs-tutorials with
|
| Latest commit: |
8087b48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d50b551.logto-docs-tutorials.pages.dev |
| Branch Preview URL: | https://yemq-add-auth-status-check.logto-docs-tutorials.pages.dev |
Deploying logto-docs with
|
| Latest commit: |
8087b48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://180bfede.logto-docs.pages.dev |
| Branch Preview URL: | https://yemq-add-auth-status-check.logto-docs.pages.dev |
charIeszhao
reviewed
Jun 16, 2025
| const validatedConfig = googleOneTapConfigSchema.parse(data); | ||
|
|
||
| localStorage.setItem(CACHE_KEY, JSON.stringify(validatedConfig)); | ||
| localStorage.setItem(CACHE_EXPIRY_KEY, String(Date.now() + CACHE_EXPIRY_TIME)); | ||
|
|
||
| setConfig(validatedConfig); | ||
| } catch (error) { | ||
| console.error('Error fetching or validating Google One Tap config:', error); | ||
| debugLogger.error('Error fetching or validating Google One Tap config:', error); | ||
| } | ||
| }; | ||
|
|
||
| void fetchConfig(); | ||
| }, [apiBaseUrl]); |
There was a problem hiding this comment.
Suggested change
| }, [apiBaseUrl]); | |
| }, [apiBaseUrl, debugLogger]); |
charIeszhao
reviewed
Jun 17, 2025
| @@ -54,7 +55,10 @@ const config: Config = { | |||
| customFields: { | |||
| inkeepApiKey: process.env.INKEEP_API_KEY, | |||
| logtoApiBaseUrl: process.env.LOGTO_API_BASE_URL, | |||
| isDevFeatureEnabled: yes(process.env.IS_DEV_FEATURE_ENABLED), | |||
| isDevFeatureEnabled: yes(process.env.IS_DEV_FEATURE_ENABLED ?? null), | |||
charIeszhao
reviewed
Jun 17, 2025
Comment on lines
+41
to
+42
| const [authStatus, setAuthStatus] = useState<boolean | undefined>(undefined); | ||
| const [authCheckError, setAuthCheckError] = useState<string | undefined>(undefined); |
There was a problem hiding this comment.
nit: Can be simplified to:
Suggested change
| const [authStatus, setAuthStatus] = useState<boolean | undefined>(undefined); | |
| const [authCheckError, setAuthCheckError] = useState<string | undefined>(undefined); | |
| const [authStatus, setAuthStatus] = useState<boolean>(); | |
| const [authCheckError, setAuthCheckError] = useState<string>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add auth status check, resolves LOG-11509