Preserve asset and scene registry entry order on update #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the asset and scene GUID registry population to maintain the original order of entries when reconstructing registries. Previously, entry order could change due to the data population approach, causing unnecessary asset rewrites and unstable scene registry updates (especially on build or play mode changes). Now, entries that already exist in the previous registry are added first in their existing order, followed by new entries. Updates the API to use TryGetEntry instead of TryGetValue for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for liris-xr/PLUME-Recorder#18
This commit updates the asset and scene GUID registry population to maintain the original order of entries when reconstructing registries. Previously, entry order could change due to the data population approach, causing unnecessary asset rewrites and unstable scene registry updates (especially on build or play mode changes). Now, entries that already exist in the previous registry are added first in their existing order, followed by new entries.
Updates the API to use TryGetEntry instead of TryGetValue for consistency.
In liris-xr/PLUME-Recorder#18 I had proposed using
GetHashCode. Turns out that is not reliable - under the hood, it usesGetInstanceID, which changes from session to session.