Skip to content

fix: remove metro peer dep from metro-transformer #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Jul 16, 2025

Description

fixes app@workspace:. doesn't provide metro (pb6ef8), requested by @lingui/metro-transformer. peer dep warning. Metro is always present with react-native and the transformer already has a peer dep on react-native.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Jul 16, 2025 8:46pm

@vonovak vonovak requested a review from andrii-bodnar July 16, 2025 20:46
Copy link

size-limit report 📦

Path Size
packages/core/dist/index.mjs 1.88 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.35 KB (0%)

@andrii-bodnar andrii-bodnar merged commit eb8a429 into main Jul 17, 2025
9 checks passed
@andrii-bodnar andrii-bodnar deleted the vonovak/fix_remove_metro_peer_dep_from_metro-transformer branch July 17, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants