Skip to content

Remove calls to TestCase::at #35473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

soilSpoon
Copy link
Contributor

It has been deprecated as of PHPUnit 9
So I refactor the test.

❯ ./vendor/bin/phpunit --stop-on-warning
PHPUnit 9.4.4 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.13
Configuration: /Users/dh/Projects/framework/phpunit.xml.dist

.............................................................   61 / 5729 (  1%)
.............................................................  122 / 5729 (  2%)
.............................................................  183 / 5729 (  3%)
.............................................................  244 / 5729 (  4%)
.............................................................  305 / 5729 (  5%)
.............................................................  366 / 5729 (  6%)
.............................................................  427 / 5729 (  7%)
.........SSSSSSSSSSSS........................................  488 / 5729 (  8%)
...................................SSSSSS....................  549 / 5729 (  9%)
...................................S.S.......................  610 / 5729 ( 10%)
.............................................................  671 / 5729 ( 11%)
.............................................................  732 / 5729 ( 12%)
....................................................W

Time: 00:00.662, Memory: 140.50 MB

There was 1 warning:

1) Illuminate\Tests\Database\DatabaseConnectionTest::testBeginTransactionMethodRetriesOnFailure
The at() matcher has been deprecated. It will be removed in PHPUnit 10. Please refactor your test to not rely on the order in which methods are invoked.

Reference

sebastianbergmann/phpunit#4297

@driesvints
Copy link
Member

Heya, thanks for this. Can you send this to 6.x instead? PHPUnit 9 is also supported there.

@driesvints driesvints closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants