Skip to content

Add ca-certificates to debian-base #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 1, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Using this image as base for other projects sometimes requires CA certificates for access to cloud APIs.
Adding CA certificates to the base image makes it easy to use ko as the build tool.

xRef:
https://github.com/golang/go/blob/go1.24.4/src/crypto/x509/root_linux.go#L9-L11

// Possible certificate files; stop after finding one.
var certFiles = []string{
	"/etc/ssl/certs/ca-certificates.crt",                // Debian/Ubuntu/Gentoo etc.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

The change is the compressed image size is very small, about 120KB (41,7MB -> 41.82MB).

image

Does this PR introduce a user-facing change?

Adds ca-certificates to debian-base image

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 1, 2025
Copy link

linux-foundation-easycla bot commented Jul 1, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hakman / name: Ciprian Hacman (ead3ad8)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority labels Jul 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jimangel July 1, 2025 13:25
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jrsapi July 1, 2025 13:25
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2025
@hakman hakman force-pushed the add-ca-certificates branch 2 times, most recently from 64bb685 to 2e8bcef Compare July 1, 2025 13:29
@hakman hakman force-pushed the add-ca-certificates branch from 2e8bcef to ead3ad8 Compare July 1, 2025 13:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 1, 2025
@hakman
Copy link
Member Author

hakman commented Jul 1, 2025

/cc @cpanato

@k8s-ci-robot k8s-ci-robot requested a review from cpanato July 1, 2025 13:36
@cpanato
Copy link
Member

cpanato commented Jul 3, 2025

lgtm in general

/assign @saschagrunert for another set of eyes

/approve
/hold

@k8s-ci-robot
Copy link
Contributor

@cpanato: GitHub didn't allow me to assign the following users: for, another, set, of, eyes.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

lgtm in general

/assign @saschagrunert for another set of eyes

/approve
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hakman, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

Thanks!

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7fb96bd into kubernetes:master Jul 3, 2025
12 checks passed
@hakman hakman deleted the add-ca-certificates branch July 3, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants