-
Notifications
You must be signed in to change notification settings - Fork 509
Add ca-certificates to debian-base #4052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
64bb685
to
2e8bcef
Compare
Signed-off-by: Ciprian Hacman <[email protected]>
2e8bcef
to
ead3ad8
Compare
/cc @cpanato |
lgtm in general /assign @saschagrunert for another set of eyes /approve |
@cpanato: GitHub didn't allow me to assign the following users: for, another, set, of, eyes. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hakman, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! /unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Using this image as base for other projects sometimes requires CA certificates for access to cloud APIs.
Adding CA certificates to the base image makes it easy to use
ko
as the build tool.xRef:
https://github.com/golang/go/blob/go1.24.4/src/crypto/x509/root_linux.go#L9-L11
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
The change is the compressed image size is very small, about 120KB (41,7MB -> 41.82MB).
Does this PR introduce a user-facing change?