Introduce API changes and fetaure gate CPU startup boost #8417

kamarabbas99 · 2025-08-07T19:14:26Z

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

API Extension: Adds a startupBoost field to the VerticalPodAutoscalerSpec and ContainerResourcePolicy to allow users to define a boost factor or quantity and a
duration.

Which issue(s) this PR fixes:

Fixes #7862

Does this PR introduce a user-facing change?

Users can now configure a startupBoost policy in the VPA spec.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: (https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/7862-cpu-startup-boost#aep-7862-cpu-startup-boost)

k8s-ci-robot · 2025-08-07T19:14:29Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-08-07T19:14:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamarabbas99
Once this PR has been reviewed and has the lgtm label, please assign omerap12 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-08-07T19:14:36Z

Hi @kamarabbas99. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

adrianmoisey · 2025-08-07T19:22:38Z

/ok-to-test

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

kamarabbas99 · 2025-08-07T20:31:36Z

/cc omerap12 laoj2

omerap12

Also missing validation: https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/7862-cpu-startup-boost#validation

This PR introduces API changes - so we need to adjust all API related stuff including validation.

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

omerap12 · 2025-08-08T08:20:00Z

vertical-pod-autoscaler/pkg/features/versioned_features.go

@@ -27,6 +27,9 @@ import (

 // Entries are alphabetized.
 var defaultVersionedFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{
+	CPUStartupBoost: {


Does CPUStartupBoost correct? I will never understand this stuff .. lol
@adrianmoisey, you are the expert on this

Yup, in this place it's correct (from what I understand)

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

adrianmoisey · 2025-08-09T09:00:00Z

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

+	// Defaults to "Factor".
+	// +unionDiscriminator
+	// +required
+	Type *StartupBoostType `json:"type,omitempty" protobuf:"bytes,1,opt,name=type"`


Required field shouldn't have omitempty: https://github.com/kubernetes-sigs/kube-api-linter/blob/main/docs/linters.md#requiredfields

Suggested change

Type *StartupBoostType `json:"type,omitempty" protobuf:"bytes,1,opt,name=type"`

Type *StartupBoostType `json:"type" protobuf:"bytes,1,opt,name=type"`

Made it optional with a default value.

adrianmoisey · 2025-08-09T09:00:50Z

vertical-pod-autoscaler/pkg/features/versioned_features.go

@@ -27,6 +27,9 @@ import (

 // Entries are alphabetized.
 var defaultVersionedFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{
+	CPUStartupBoost: {


Yup, in this place it's correct (from what I understand)

vertical-pod-autoscaler/pkg/features/features.go

adrianmoisey · 2025-08-09T09:05:42Z

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler.go

+	if boostType == nil {
+		// Default to Factor when type is not specified.
+		defaultType := vpa_types.FactorStartupBoostType
+		boostType = &defaultType
+	}


I see that in the API type is marked as required, I'm wondering if that is incorrect?

Made the API field optional with default value of Factor.

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler.go

laoj2 · 2025-08-11T13:33:22Z

vertical-pod-autoscaler/pkg/features/versioned_features.go

@@ -27,6 +27,9 @@ import (

 // Entries are alphabetized.
 var defaultVersionedFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{
+	CPUStartupBoost: {
+		{Version: version.MustParse("1.5"), Default: false, PreRelease: featuregate.Alpha},


@adrianmoisey with InPlaceOrRecreate graduating to Beta in 1.5 (https://github.com/kubernetes/autoscaler/pull/8423/files), does it make sense to make CPU boost available in 1.6+? So it doesn't block the graduation?

Not sure I understand, are you suggestion that CPUStartupBoost be available in 1.6 as alpha (default off) or as something else?
Why can't CPUStartupBoost be available as alpha (default off) in 1.5?

It could be available as alpha in 1.5. I'm suggesting that we could release CPU boost in another version (e.g 1.6), because CPU boost is not code complete/(stable too?) yet and we may want to cut a new VPA 1.5.0 release soon (to introduce InPlaceOrRecreate beta) without being blocked by this feature.

I see.
Well, if this feature is ready by the time we cut 1.5.0 (which may be soon after Kubernetes 1.34, I assume?), then it can go into 1.5.0.
If the feature is not code complete, and PRs not merged into 1.5.0, that's fine too, we just wait until 1.6.0

Agree with Adrian.

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go

adrianmoisey · 2025-08-11T18:24:55Z

So far so good. The flag docs just need updating, then it think it's good to go

laoj2

Thanks @kamarabbas99!

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go

laoj2 · 2025-08-11T20:27:37Z

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler.go

+			return fmt.Errorf("invalid StartupBoost.CPU.Quantity: %v", err)
+		}
+	}
+	return nil


what about checking if both Factor and Quantity are set at the same time? (So we ensure only one of them is set at a time)

This should be done via union no?
https://github.com/kubernetes/autoscaler/pull/8417/files#diff-5354b25f63881cd841f3b7bdf7e6bb912004554d1cd8926a0ae61a2840af7343R130

https://github.com/kubernetes/autoscaler/pull/8417/files#diff-5354b25f63881cd841f3b7bdf7e6bb912004554d1cd8926a0ae61a2840af7343R142

Awesome, I missed that! Thanks @omerap12

vertical-pod-autoscaler/docs/features.md

adrianmoisey · 2025-08-14T05:02:22Z

Oh, and there's a script to update the API docs too: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/hack/generate-api-docs.sh
(we really need to be better at adding these things to CI)

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/vertical-pod-autoscaler labels Aug 7, 2025

k8s-ci-robot requested review from jbartosik and raywainman August 7, 2025 19:14

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Aug 7, 2025

kamarabbas99 mentioned this pull request Aug 7, 2025

VPA: Implement startup CPU boost support #8413

Draft

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2025

adrianmoisey reviewed Aug 7, 2025

View reviewed changes

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go Outdated Show resolved Hide resolved

adrianmoisey reviewed Aug 7, 2025

View reviewed changes

vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go Outdated Show resolved Hide resolved

k8s-ci-robot requested review from laoj2 and omerap12 August 7, 2025 20:31

kamarabbas99 force-pushed the feature-cpu-boost-api branch 2 times, most recently from 5bd5b24 to 6415e36 Compare August 7, 2025 21:02

omerap12 reviewed Aug 8, 2025

View reviewed changes

kamarabbas99 force-pushed the feature-cpu-boost-api branch from 6415e36 to 4f0b0b3 Compare August 8, 2025 18:11

adrianmoisey reviewed Aug 9, 2025

View reviewed changes

laoj2 reviewed Aug 11, 2025

View reviewed changes

kamarabbas99 force-pushed the feature-cpu-boost-api branch from 4f0b0b3 to 25eab9b Compare August 11, 2025 13:54

kamarabbas99 force-pushed the feature-cpu-boost-api branch from 25eab9b to 3159fb2 Compare August 11, 2025 13:58

adrianmoisey reviewed Aug 11, 2025

View reviewed changes

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go Outdated Show resolved Hide resolved

kamarabbas99 force-pushed the feature-cpu-boost-api branch from 3159fb2 to ded6238 Compare August 11, 2025 17:42

laoj2 reviewed Aug 11, 2025

View reviewed changes

kamarabbas99 force-pushed the feature-cpu-boost-api branch from ded6238 to 609f127 Compare August 12, 2025 20:49

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2025

adrianmoisey reviewed Aug 13, 2025

View reviewed changes

vertical-pod-autoscaler/docs/features.md Show resolved Hide resolved

adrianmoisey reviewed Aug 13, 2025

View reviewed changes

vertical-pod-autoscaler/docs/features.md Outdated Show resolved Hide resolved

adrianmoisey reviewed Aug 13, 2025

View reviewed changes

vertical-pod-autoscaler/docs/features.md Outdated Show resolved Hide resolved

kamarabbas99 force-pushed the feature-cpu-boost-api branch from 609f127 to 89d5553 Compare August 13, 2025 20:41

Introduce API changes and fetaure gate CPU startup boost

908d6e0

kamarabbas99 force-pushed the feature-cpu-boost-api branch from 89d5553 to 908d6e0 Compare August 13, 2025 20:42

	Type *StartupBoostType `json:"type,omitempty" protobuf:"bytes,1,opt,name=type"`
	Type *StartupBoostType `json:"type" protobuf:"bytes,1,opt,name=type"`

Introduce API changes and fetaure gate CPU startup boost #8417

Are you sure you want to change the base?

Introduce API changes and fetaure gate CPU startup boost #8417

Uh oh!

Conversation

kamarabbas99 commented Aug 7, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Aug 7, 2025

Uh oh!

k8s-ci-robot commented Aug 7, 2025

Uh oh!

k8s-ci-robot commented Aug 7, 2025

Uh oh!

adrianmoisey commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

kamarabbas99 commented Aug 7, 2025

Uh oh!

omerap12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kamarabbas99 Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adrianmoisey commented Aug 11, 2025

Uh oh!

laoj2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adrianmoisey commented Aug 14, 2025

Uh oh!

kamarabbas99 Aug 11, 2025 •

edited

Loading