-
Notifications
You must be signed in to change notification settings - Fork 4.2k
adds datacrunch provider #8351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
adds datacrunch provider #8351
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maaft The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @maaft! |
Hi @maaft. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
FYI; currently refactoring and simplifying the startup script logic. Will push another commit soon. |
@aleksandra-malinowska @vadasambar anything I can do to get this merged? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@maaft you'll have to add a datacrunch-specific build tag, see how this recently added provider did it:
Additionally, you'll need to ship an OWNERS file so that the provider source can be self-maintained going forward, e.g.: |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds support for datacrunch provider
Which issue(s) this PR fixes:
Fixes #8350
Special notes for your reviewer:
Since I do not work for datacrunch, it would be probably a good idea if anyone from them could review this PR.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: