WIP: Update cluster-api provider to use machineTemplate.status.nodeInfo for architecture-aware autoscale from zero #8345
+283
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/L
aleskandro
force-pushed
the
arch-aware-node-info
branch
5 times, most recently
from
dd56e8b to
13dea52
Compare
aleskandro
commented
Jul 23, 2025
cluster-autoscaler/cloudprovider/clusterapi/clusterapi_controller_test.go
Outdated
Show resolved
Hide resolved
aleskandro
force-pushed
the
arch-aware-node-info
branch
2 times, most recently
from
8ec180c to
c3a296a
Compare
k8s-ci-robot
added
release-note
aleskandro
changed the title
aleskandro
force-pushed
the
arch-aware-node-info
branch
from
c3a296a to
98c4898
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aleskandro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aleskandro
force-pushed
the
arch-aware-node-info
branch
3 times, most recently
from
21705b1 to
9f183df
Compare
elmiko
reviewed
Aug 6, 2025
cluster-autoscaler/cloudprovider/clusterapi/clusterapi_controller_test.go
Outdated
Show resolved
Hide resolved
| // InstanceSystemInfo sets the nodeSystemInfo from the infrastructure reference resource. | ||
| // If the infrastructure reference resource is not found, returns nil. | ||
| func (r unstructuredScalableResource) InstanceSystemInfo() *apiv1.NodeSystemInfo { | ||
| infraObj, err := r.readInfrastructureReferenceResource() |
There was a problem hiding this comment.
something i am concerned about is the notion that we will be calling this function twice for every node template we create. each call to this function results in another call to the api server to get the infrastructure machine template. i think we need to find a way to combine the call required in this function with the call we make in the InstanceCapacity call.
There was a problem hiding this comment.
To keep having two separate functions and avoid coupling, I've made a change to the readInfrastructureReferenceResource to cache the infraObj via lazy loading. Wdyt?
cluster-autoscaler/cloudprovider/clusterapi/clusterapi_unstructured_test.go
Show resolved
Hide resolved
aleskandro
force-pushed
the
arch-aware-node-info
branch
from
9f183df to
9d1c610
Compare
…r architecture-aware autoscale from zero kubernetes-sigs/cluster-api#11962 introduced the nodeInfo field for MachineTemplates. Providers can reconcile this field in the status subresource to inform the autoscaler about the architecture and operating system that the MachineTemplate's nodes will run. Previously, we have been implementing this behavior in the cluster autoscaler by leveraging the labels capacity annotation and, as a fallback, default values set in environment variables at cluster-autoscaler deployment time. With this commit, the cluster autoscaler computes the future architecture of a node with the following priority order: - Labels set in existing nodes for not-autoscale-from-zero cases - Labels set in the labels capacity annotation of machine template, machine set, and machine deployment. - Values in the status.nodeSystemInfo of MachineTemplates - Generic/default labels set in the environment of the cluster autoscaler
aleskandro
force-pushed
the
arch-aware-node-info
branch
from
9d1c610 to
7e356f2
Compare
…eInfo for architecture-aware autoscale from zero kubernetes-sigs/cluster-api#11962 introduced the nodeInfo field for MachineTemplates. Providers can reconcile this field in the status subresource to inform the autoscaler about the architecture and operating system that the MachineTemplate's nodes will run. Previously, we have been implementing this behavior in the cluster autoscaler by leveraging the labels capacity annotation and, as a fallback, default values set in environment variables at cluster-autoscaler deployment time. With this commit, the cluster autoscaler computes the future architecture of a node with the following priority order: - Labels set in existing nodes for not-autoscale-from-zero cases - Labels set in the labels capacity annotation of machine template, machine set, and machine deployment. - Values in the status.nodeSystemInfo of MachineTemplates - Generic/default labels set in the environment of the cluster autoscaler
aleskandro
force-pushed
the
arch-aware-node-info
branch
from
7e356f2 to
8b78773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubernetes-sigs/cluster-api#11962 introduced the nodeInfo field for MachineTemplates. Providers can reconcile this field in the status subresource to inform the autoscaler about the architecture and operating system that the MachineTemplate's nodes will run.
Previously, we have been implementing this behavior in the cluster autoscaler by leveraging the labels capacity annotation and, as a fallback, default values set in environment variables at cluster-autoscaler deployment time.
With this commit, the cluster autoscaler computes the future architecture of a node with the following priority order:
Which issue(s) this PR fixes:
Fixes #8347
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: