Skip to content

perf: Add an option to skip OpenAPI schema initialization #5932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iliakonnov
Copy link

This PR introduces a new skip field to the openapi map in the kustomization file.

Problem

When using Kustomize as a library, Kustomizer.Run calls openapi.SetSchema on every execution. In high-frequency scenarios where the same schema is used repeatedly, this leads to a significant performance bottleneck due to redundant schema compilation.

In our use case, we call Kustomizer.Run thousands of times. Flame graph analysis showed that schema compilation was a major contributor to the overall execution time.

Solution

By setting openapi.skip to true, users can now bypass the call to openapi.SetSchema inside Kustomizer.Run. This allows library consumers to initialize the schema once at application startup and reuse it for all subsequent runs.

Example workflow:

  1. Initialize the schema manually once when your application starts: openapi.SetSchema(...).
  2. In your kustomization.yaml, add the skip field:
openapi:
  skip: true
  1. Call kustomizer.Run() as usual.

Result

This change dramatically improves performance in our scenario, reducing the total processing time from 30 minutes to 9 minutes.

Next Steps and Design Alternatives

I've submitted this patch as a minimal implementation to start a discussion and validate the approach. I'm keen to hear your feedback and I'm ready to make adjustments.

Here are a few alternatives I've considered:

  1. Instead of modifying the public kustomization.yaml format, we could add a new field directly to the Kustomizer struct (e.g., Kustomizer.SkipOpenAPISchema). This would make the feature available only when Kustomize is used as a library, which is the primary use case for this optimization. I'm happy to implement it this way if you prefer.
  2. The field name skip is a placeholder. A more descriptive name like usePreconfiguredSchema or built-in might be better. I don't have a strong preference and am open to suggestions.

My main goal is to get early feedback on whether this direction for performance improvement is welcome before investing more time.

Copy link

linux-foundation-easycla bot commented Jun 26, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iliakonnov
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @iliakonnov!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @iliakonnov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants