-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Change failure condition for image container download #12321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
When installing with `download_run_once`, nerdctl will log to stderr and cause a failure even if the image was saved successfully. Signed-off-by: Alejandro Macedo <[email protected]>
The committers listed above are authorized under a signed CLA. |
Welcome @AMacedoP! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AMacedoP The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @AMacedoP. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
When installing with
download_run_once
, nerdctl will log to stderr and cause a failure even if the image was saved successfully.What type of PR is this?
/kind bug
What this PR does / why we need it:
When installing with
download_run_once
, nerdctl will log to stderr and cause a failure even if the image was saved successfully.Does this PR introduce a user-facing change?: