Refactor download (file) #12299
Draft
Refactor download (file) #12299
+285
−569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same logic as system_packages: we simply let jinja expand our variables to a list of boolean and filter on this.
Delegate to everything to download_delegate.
group hosts by "delegate" then loops on the delegate with extract on hostvars. This shortcircuit the loop earlier than using selectattr on the whole hostvars on every host.
Small efficiency gains when downloading, around 2-3s worse when everything is already there.
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-action-required
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XL
|
Also, I think the approach could make manage-offline.sh redundant (aka, just run the download tags on a non offline control node, copy the local_release_dir, done)
I'm not super into that so might not be enough though
|
Some stuff used on localhost (skopeo for download images, for instances) may need the machine architecture and similar things, so collect facts for localhost as well
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
This should fix multi-arch cluster download, and be much more scalable. (rough testing of the file part only:
-> around 1 minutes for 1000 fake hosts with download_delegate == localhost)
This is only the file part, I plan to handle containers images in a separate PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm working on this still, so expect heavy rebasing and force push. I think the design of the role will stay like this though.
Does this PR introduce a user-facing change?: