Skip to content

Add flag to determine whether containerd config is overwritten #12278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Add flag to determine whether containerd config is overwritten #12278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions roles/container-engine/containerd/defaults/main.yml
View file
Original file line number Diff line number Diff line change
@@ -126,3 +126,8 @@ containerd_tracing_endpoint: "[::]:4317"
containerd_tracing_protocol: "grpc"
containerd_tracing_sampling_ratio: 1.0
containerd_tracing_service_name: "containerd"

# Determines whether to overwrite an existing containerd config
# Defaults to true for backwards compatibility, but can be set to false when applications
# that modify the containerd config are deployed on the cluster, e.g. NVIDIA gpu-operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add here a TODO comment referencing the nvidia-gpu-operator, so we have some reference to when we'll be able to cleanup the workaround ? I believe that'd be NVIDIA/nvidia-container-toolkit#1067, correct ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is sensible - I will sort that out.

containerd_config_overwrite: true
1 change: 1 addition & 0 deletions roles/container-engine/containerd/tasks/main.yml
View file
Original file line number Diff line number Diff line change
@@ -70,6 +70,7 @@
dest: "{{ containerd_cfg_dir }}/config.toml"
owner: "root"
mode: "0640"
force: "{{ containerd_config_overwrite }}"
notify: Restart containerd

- name: Containerd | Configure containerd registries