feat: Add cilium_install_extra_args

[tmurakam]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add cilium_install_extra_args variable for cilium install command.

This enables to use such as --chart-directory or --repository option to enable offline installation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add cilium_install_extra_args variable

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tmurakam]

@tico88612
Could you check this?
This is needed for offline installation, because without --chart-directory option, cilium install pulls the chart from the Internet.

[tmurakam]

/ok-to-test

[cyclinder]

thanks

[michelaldaher]

Hello,

I have found also that whenever we relaunch the cluster.yml playbook the second time is failing as cillium was already installed, can we replace it with upgrade ? but i did not find any flag --install to add to it. this is the error

TASK [network_plugin/cilium : Cilium | Install] *************************************************************************************************************************************************************************************
fatal: [yuv-offline-m]: FAILED! => {"changed": true, "cmd": ["/usr/local/bin/cilium", "install", "--version", "1.17.3", "--chart-directory", "/etc/kubernetes/cilium", "-f", "/etc/kubernetes/cilium-values.yaml"], "delta": "0:00:00.129057", "end": "2025-05-27 12:24:35.385909", "msg": "non-zero return code", "rc": 1, "start": "2025-05-27 12:24:35.256852", "stderr": "\nError: Unable to install Cilium: cannot re-use a name that is still in use", "stderr_lines": ["", "Error: Unable to install Cilium: cannot re-use a name that is still in use"], "stdout": "ℹ️ Using Cilium version 1.17.3\nℹ️ Using cluster name "default"\n🔮 Auto-detected kube-proxy has not been installed\nℹ️ Cilium will fully replace all functionalities of kube-proxy", "stdout_lines": ["ℹ️ Using Cilium version 1.17.3", "ℹ️ Using cluster name "default"", "🔮 Auto-detected kube-proxy has not been installed", "ℹ️ Cilium will fully replace all functionalities of kube-proxy"]}

NO MORE HOSTS LEFT ******************************************************************************************************************************************************************************************************************

PLAY RECAP **************************************************************************************************************************************************************************************************************************
test-m : ok=531 changed=13 unreachable=0 failed=1 skipped=619 rescued=0 ignored=2
test-w : ok=404 changed=8 unreachable=0 failed=0 skipped=460 rescued=0 ignored=2

i had also a problem with a missing image for cilium-operator-generic that I had to re-push manually

[tico88612]

This change is even better, but I'm trying to think of a more suitable name for it.

@michelaldaher off-topic with this PR, and this is a known issue. (BTW, cilium cli not support upgrade --install command) Could you try #12254 and report there? Thanks

[tico88612]

I have some ideas, what do you think about cilium_install_args? I found that the arguments for cilium install and cilium upgrade are little different.

[tmurakam]

@tico88612
I'm a little concerned that the variable doesn't include --version and -f options, but overall I agree.
I will update this PR.

[tico88612]

Oh, if this is a little confusing, what about cilium_install_extra_flags?
This will not conflict with any existing Kubernetes naming conventions.

[tmurakam]

Ok, I updated the PR and title/description.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cyclinder, tmurakam
Once this PR has been reviewed and has the lgtm label, please assign vannten for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tico88612]

Little comment.

cilium_install_extra_flags would be better, as args could be confused with the pod's args.