Skip to content

Fixed syntax error in _bgp_config dict #12258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathgaming
Copy link

@mathgaming mathgaming commented May 25, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes a syntax error that made the _bgp_config an AnsibleUnsafeText instead of a dict.

TASK [network_plugin/calico : Calico | Process BGP Configuration]
fatal: [node1]: FAILED! => {"msg": "failed to combine variables, expected dicts but got a 'dict' and a 'AnsibleUnsafeText':

Which issue(s) this PR fixes:
Before the fix:

"_bgp_config": "{\n  \"kind\": \"BGPConfiguration\",\n  \"apiVersion\": \"projectcalico.org/v3\",\n  \"metadata\": {\n    \"name\": \"default\",\n  },\n  \"spec\": {\n    \"listenPort\": 179,\n    \"logSeverityScreen\": \"Info\",\n    \"asNumber\": 64512,    \"nodeToNodeMeshEnabled\": False ,\n        \"serviceClusterIPs\": >-[{\"cidr\": \"10.233.0.0/18\"}],    \"serviceLoadBalancerIPs\": [{'cidr': '172.16.8.0/24'}],    \"serviceExternalIPs\": []\n  }\n}\n"

After the fix:

"_bgp_config": {
    "apiVersion": "projectcalico.org/v3",
    "kind": "BGPConfiguration",
    "metadata": {
        "name": "default"
    },
    "spec": {
        "asNumber": 64512,
        "listenPort": 179,
        "logSeverityScreen": "Info",
        "nodeToNodeMeshEnabled": false,
        "serviceClusterIPs": [
            {
                "cidr": "10.233.0.0/18"
            }
        ],
        "serviceExternalIPs": [],
        "serviceLoadBalancerIPs": [
            {
                "cidr": "172.16.8.0/24"
            }
        ]
    }
}

Special notes for your reviewer:
The playbook finished without errors when I ran it locally after the fix

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 25, 2025
Copy link

linux-foundation-easycla bot commented May 25, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mathgaming
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from tico88612 and VannTen May 25, 2025 18:28
@k8s-ci-robot
Copy link
Contributor

Welcome @mathgaming!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mathgaming. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 25, 2025
@yankay
Copy link
Member

yankay commented Jun 3, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2025
@VannTen
Copy link
Contributor

VannTen commented Jun 5, 2025

/retest

@VannTen
Copy link
Contributor

VannTen commented Jun 5, 2025

This needs a proper release-note

@woopstar
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@tico88612
Copy link
Member

Need rebase and release note

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants