Skip to content

Update pre-commit and put ansible-lint at the end #12186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 2, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
pre-commit: move ansible-lint at the end

Ansible-lint is the most expensive hook we have.

Run it at the end to fail faster if any of the others hooks have
something to say.

Also autoupdate our hooks.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from tico88612 and yankay May 2, 2025 14:19
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2025
@VannTen
Copy link
Contributor Author

VannTen commented May 2, 2025

I had the ansible-lint error for a while locally, it seems to have weird trigger condition:
ansible/ansible-lint#4579 might be the issue, not sure.

@tico88612
Copy link
Member

Rebase again?

VannTen added 2 commits June 5, 2025 09:26
Ansible-lint is the most expensive hook we have.

Run it at the end to fail faster if any of the others hooks have
something to say.
@VannTen VannTen force-pushed the pre-commit/update branch from 5cdd976 to a82016c Compare June 5, 2025 07:27
@VannTen
Copy link
Contributor Author

VannTen commented Jun 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants