Skip to content

Support fedora42 #12133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support fedora42 #12133

wants to merge 2 commits into from

Conversation

0ekk
Copy link
Member

@0ekk 0ekk commented Apr 18, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Fedora 42 has been released recently(https://docs.fedoraproject.org/en-US/fedora/f42/release-notes/). It is believed that many people want to try the latest kubernetes within this distro release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support for Fedora 42

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0ekk
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mzaian and yankay April 18, 2025 10:25
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 18, 2025
@0ekk 0ekk force-pushed the support-fedora42 branch from 75c08ad to ba5a8f9 Compare April 18, 2025 10:35
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2025
@0ekk
Copy link
Member Author

0ekk commented Apr 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 18, 2025
@0ekk 0ekk force-pushed the support-fedora42 branch from ba5a8f9 to b5d0af3 Compare April 18, 2025 10:48
@0ekk
Copy link
Member Author

0ekk commented Apr 18, 2025

/label ci-extended

@k8s-ci-robot k8s-ci-robot added the ci-extended Run additional tests label Apr 18, 2025
@0ekk 0ekk force-pushed the support-fedora42 branch from b5d0af3 to ee86e6d Compare April 18, 2025 11:12
tico88612
tico88612 reviewed Apr 18, 2025
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review.

.gitlab-ci/kubevirt.yml Outdated
@@ -119,6 +119,7 @@ pr_extended:
- debian11-docker
- debian12-calico
- debian12-docker
- fedora42-calico
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this in pr-extended? Have any particular reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the priority of the CI for fedora42, so I'll temporarily place it in pr-extended for now.
What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just put it in a normal PR job first and discuss with other members where to put it. Using pr-extended will enable extra work and add an extra computational burden.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me.

@0ekk 0ekk force-pushed the support-fedora42 branch from ee86e6d to 6bb87e8 Compare April 18, 2025 15:36
@tico88612
Copy link
Member

/remove-label ci-extended

@k8s-ci-robot k8s-ci-robot removed the ci-extended Run additional tests label Apr 18, 2025
@0ekk
Add CI for Fedora 42
b468ac2 
Signed-off-by: Ekko Tu <[email protected]>
@0ekk 0ekk force-pushed the support-fedora42 branch from 6bb87e8 to b468ac2 Compare April 18, 2025 15:51
@tico88612
Copy link
Member

#12138 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 left review comments

@mzaian mzaian Awaiting requested review from mzaian

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0ekk @k8s-ci-robot @tico88612