Skip to content

Update the OVA test script to dynamically detect targets to test #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

Update the OVA test script to dynamically detect targets to test #1781

merged 1 commit into from
Jul 2, 2025
+16 −1

Conversation

AverageMarcus
Copy link
Member

@AverageMarcus AverageMarcus commented Jun 24, 2025 •
edited
Loading

Change description

Updates the OVA test script to dynamically detect target OSs we support and run tests for those.
We also filter out the following:

  • Any RHEL targets (because of subscription requirements)
  • Any Windows targets (because of license requirements)
  • Any efi targets (to reduce duplicate OSs)

The following are also filtered out as I'm unable to currently get them to work in our test environment:

  • Photon-4
  • RockyLinux-8

(If anyone can help with these I'd really appreciate it. I'll open issues to remove these exclusions after this PR is merged so we can work on supporting these too)

This results in, currently, the following targets:

build-node-ova-vsphere-photon-5
build-node-ova-vsphere-rockylinux-9
build-node-ova-vsphere-ubuntu-2004
build-node-ova-vsphere-ubuntu-2204
build-node-ova-vsphere-ubuntu-2404
build-node-ova-vsphere-flatcar

Related issues

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2025
@chrischdi
Copy link
Member

/retest

@chrischdi
Copy link
Member

chrischdi commented Jun 24, 2025 •
edited
Loading

It this for flatcar:

�[1;31mBuild 'vsphere-iso.vsphere' errored after 2 minutes 14 seconds: Post "https://192.168.31.2/sdk": dial tcp 192.168.31.2:443: connect: connection timed out�[0m

We did see a similar thing in CAPV too.

Let's add something to e2e.sh to wait for the connection to be up, like here (without the if part), maybe needs to replace VSPHERE_SERVER by GOVC_URL or so:

https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/hack/e2e.sh#L141-L166

@AverageMarcus
Copy link
Member Author

Looks like the filtering isn't working correctly with that version of grep anyway. 🤦 I'll pick this back up later. Will convert to WIP for now.

@AverageMarcus AverageMarcus marked this pull request as draft June 24, 2025 11:56
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2025
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

1 similar comment
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2025
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

1 similar comment
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@AverageMarcus AverageMarcus force-pushed the ova-test-targets branch 2 times, most recently from dbc8856 to 44e4c9e Compare June 26, 2025 14:17
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2025
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@chrischdi
Copy link
Member

/test pull-ova-all

@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@AverageMarcus
Copy link
Member Author

RockyLinux-8 is failing with

Build 'vsphere-iso.vsphere' errored after 3 seconds 634 milliseconds: No host is compatible with the virtual machine.

Is it possibly an incompatibility with the version of vsphere? Maybe we just need to exclude this one too?

@AverageMarcus
Copy link
Member Author

/test pull-ova-all

2 similar comments
@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@AverageMarcus
Copy link
Member Author

/test pull-ova-all

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2025
@AverageMarcus
Update the OVA test script to dynamically detect targets to test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
07790a0 
Signed-off-by: Marcus Noble <[email protected]>
@AverageMarcus AverageMarcus marked this pull request as ready for review July 1, 2025 10:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jsturtevant July 1, 2025 10:36
@drew-viles
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@AverageMarcus
Copy link
Member Author

/assign @mboersma

@chrischdi
Copy link
Member

/lgtm

For rocky 8: it propably needs something similar to:

https://github.com/kubernetes-sigs/image-builder/blob/main/images/capi/packer/ova/rockylinux-9.json#L19

But fine as follow-up.

mboersma
mboersma approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4ab7b02 into kubernetes-sigs:main Jul 2, 2025
7 checks passed
@AverageMarcus AverageMarcus mentioned this pull request Jul 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi

@mboersma mboersma

@drew-viles drew-viles

@kkeshavamurthy kkeshavamurthy

@jsturtevant jsturtevant

Assignees

@mboersma mboersma

@chrischdi chrischdi

@drew-viles drew-viles

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AverageMarcus @chrischdi @drew-viles @k8s-ci-robot @mboersma