✨ Remove pointer, add omitzero & MinProperties for initialization fields/structs #12482
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/assign @fabriziopandini |
sbueringer
force-pushed
the
pr-init-fixups
branch
from
6fd1997 to
438ce9e
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: babf2b4fce1719f05b1c1ae52e4760a769141eb4
|
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
I'll do some more cleanup |
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/XXL
sbueringer
force-pushed
the
pr-init-fixups
branch
from
30f97d5 to
afdccc9
Compare
|
/test pull-cluster-api-e2e-main |
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-init-fixups
branch
from
afdccc9 to
4fea3b8
Compare
|
/test pull-cluster-api-e2e-main |
|
that's a nice simplification! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fb8432c3a430f17a99acab1bc42341c9ffb445a2
|
|
/override pull-cluster-api-e2e-main |
|
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-init-fixups
branch
from
4fea3b8 to
2c03b5a
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
/test pull-cluster-api-e2e-main |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5fd617b2471d34a46a12c2790e018cb5877596f9
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-cluster-api-e2e-main https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api/12482/pull-cluster-api-e2e-main/1944751337103167488 seems unrelated but let's see |
|
Took a closer look. Failure is unrelated to this PR, will open a PR against main to fix it (#12488) /override pull-cluster-api-e2e-main |
|
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Dropped the pointer from Initialization status structs. I think it's much much cleaner this way and the fields in initialization are much easier to use now
& follow-ups to:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11947