Skip to content

🌱 test: enable upgrades for scale-test and bump CAPI to d5158c2503c84bcf2fc35cf463fca486892b5fae #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2025
Merged

🌱 test: enable upgrades for scale-test and bump CAPI to d5158c2503c84bcf2fc35cf463fca486892b5fae #3343

merged 2 commits into from
Feb 11, 2025

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Bump is required to have kubernetes-sigs/cluster-api#11798

Variable renaming was due to CAPI PR kubernetes-sigs/cluster-api#11743

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@chrischdi
Copy link
Member Author

/tide merge-method/squash

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2025
@chrischdi
Copy link
Member Author

/tide merge-method-squash

@chrischdi
Copy link
Member Author

/label tide/merge-method/squash

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) /label tide/merge-method/squash cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label tide/merge-method/squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 6, 2025
@chrischdi
Copy link
Member Author

/assign @sbueringer @fabriziopandini

@fabriziopandini
Copy link
Member

lgtm
pending test flake investigation

@chrischdi
Copy link
Member Author

chrischdi commented Feb 6, 2025 •
edited
Loading

/retest

Flake. I slowly lean towards rewrite that test...

@chrischdi
Copy link
Member Author

/retest

@sbueringer
Copy link
Member

/approve
Thx!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@chrischdi
Copy link
Member Author

/retest

@chrischdi chrischdi force-pushed the pr-scale-upgrade-bump-capi branch from e5c1785 to 793bc6f Compare February 7, 2025 15:19
@chrischdi
Copy link
Member Author

chrischdi commented Feb 7, 2025 •
edited
Loading

Note, still have to look into govmomi

@sbueringer
Copy link
Member

Just ping me when I should take another look

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc189dc122539733cbcf5c2c6c2fc46afaa50a3f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member Author

unrelated flake (still looking at it though)

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3046910 into kubernetes-sigs:main Feb 11, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@yastij yastij Awaiting requested review from yastij

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @fabriziopandini @sbueringer